Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to register background callback #31

Merged
merged 3 commits into from
Nov 20, 2021
Merged

Fix failure to register background callback #31

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55d7152
Fix failure to register background callback #27
Jul 20, 2021
35cab74
Casting with Number
aljkor Jul 20, 2021
6d9ef34
Update android/src/main/kotlin/es/antonborri/home_widget/HomeWidgetPl…
aljkor Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/kotlin/es/antonborri/home_widget/HomeWidgetPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ class HomeWidgetPlugin : FlutterPlugin, MethodCallHandler, ActivityAware,
}
}
"registerBackgroundCallback" -> {
val dispatcher = (call.arguments as Iterable<*>).toList()[0] as Long
val callback = (call.arguments as Iterable<*>).toList()[1] as Long
val dispatcher = (call.arguments as Iterable<*>).toList()[0].toString().toLong()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting this toString feels really hacky. I guess it would also work if you cast the argument with as Number and call toLong on that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree this is a less hacky solution, I implemented it and it works this way too. I fixed to casting as Number and then calling toLong()

val callback = (call.arguments as Iterable<*>).toList()[1].toString().toLong()
saveCallbackHandle(context, dispatcher, callback)
return result.success(true)
}
Expand Down