Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include pressure in x-momentum flux in 1-d Cartesian #2468

Merged
merged 14 commits into from
Oct 5, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented May 26, 2023

PR summary

previously, we were explicitly adding the pressure gradient in the conservative update
to the momentum for all 1-d geometries. But we were only doing the flux correction
on P_radial for non-Cartesian geometries. Now we treat all Cartesian geometries the
same, regardless of dimensionality.

This will likely change 1-d Cartesian answers.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented May 26, 2023

tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-05-26-001/index.html

I need to understand what's happening with the SDC. I am probably double-counting there.

@zingale
Copy link
Member Author

zingale commented May 29, 2023

@zingale
Copy link
Member Author

zingale commented May 29, 2023

it looks like the 1-d true SDC tests are now roundoff, although I am not sure why we'd even get that change.

@maxpkatz
Copy link
Member

Do you know what is up with rad2Tshock-1D in that test suite run?

@zingale
Copy link
Member Author

zingale commented May 31, 2023

the grids are different, so fcompare aborted.

@zingale zingale added the hydro label Oct 2, 2023
@zingale
Copy link
Member Author

zingale commented Oct 5, 2023

Here's the true-SDC (2nd order) Sod problem

sod_1d

@zingale
Copy link
Member Author

zingale commented Oct 5, 2023

and here's the 4th order true-SDC Sod problem

sod_1d

@zingale
Copy link
Member Author

zingale commented Oct 5, 2023

Here's the PPM Sod problem with 2 levels of refinement, again using this PR

sod_1d

@zingale
Copy link
Member Author

zingale commented Oct 5, 2023

Here's a 2D sph_in_cylcoords Sedov with 4 levels

sedov_2d_sph_in_cyl

@zingale
Copy link
Member Author

zingale commented Oct 5, 2023

closes #2467

@zingale
Copy link
Member Author

zingale commented Oct 5, 2023

tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-10-05-002/index.html

most are reasonable, but with Detonation, all bets are off (as always).

@zingale zingale merged commit 2c65efc into AMReX-Astro:development Oct 5, 2023
18 checks passed
@zingale zingale deleted the make_1d_cart_mom_have_p branch October 5, 2023 17:26
zingale pushed a commit that referenced this pull request Nov 17, 2024
addresses #2803 . In #2468, we modified mom_flux_has_p to include pressure in momentum flux with 1d cartesian, so we don't need to scale pressure again scale_flux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants