-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include pressure in x-momentum flux in 1-d Cartesian #2468
include pressure in x-momentum flux in 1-d Cartesian #2468
Conversation
tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-05-26-001/index.html I need to understand what's happening with the SDC. I am probably double-counting there. |
it looks like the 1-d true SDC tests are now roundoff, although I am not sure why we'd even get that change. |
Do you know what is up with rad2Tshock-1D in that test suite run? |
the grids are different, so fcompare aborted. |
closes #2467 |
tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-10-05-002/index.html most are reasonable, but with Detonation, all bets are off (as always). |
PR summary
previously, we were explicitly adding the pressure gradient in the conservative update
to the momentum for all 1-d geometries. But we were only doing the flux correction
on P_radial for non-Cartesian geometries. Now we treat all Cartesian geometries the
same, regardless of dimensionality.
This will likely change 1-d Cartesian answers.
PR motivation
PR checklist
CHANGES
file has been updated, if appropriate