Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra pressure scale in scale_flux for 1d cartesian #2991

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

zhichen3
Copy link
Collaborator

PR summary

addresses #2803 . In #2468, we modified mom_flux_has_p to include pressure in momentum flux with 1d cartesian, so we don't need to scale pressure again scale_flux.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zhichen3 zhichen3 marked this pull request as ready for review November 12, 2024 18:15
@zingale
Copy link
Member

zingale commented Nov 12, 2024

@zingale zingale merged commit be78430 into AMReX-Astro:development Nov 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants