Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PureSoA IdCpu fixes #3671

Merged
merged 1 commit into from
Dec 15, 2023
Merged

PureSoA IdCpu fixes #3671

merged 1 commit into from
Dec 15, 2023

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Dec 14, 2023 •
edited
Loading

Summary

I noticed a few issues in AMReX while trying to update HiPACE++ for #3585.

Additionally, I would like to point out that ParticleTile has push_back_real and push_back_int functions but for PureSoA there is no push_back_idcpu, however this is not added in this PR.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers merged commit 554b1ca into AMReX-Codes:development Dec 15, 2023
69 checks passed
@ax3l
Copy link
Member

ax3l commented Dec 15, 2023

Thank you, @AlexanderSinn 👍

@AlexanderSinn AlexanderSinn mentioned this pull request Dec 15, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmyers atmyers atmyers approved these changes

@ax3l ax3l Awaiting requested review from ax3l

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderSinn @ax3l @atmyers