Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 64 bit idcpu #1047

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Dec 12, 2023

After AMReX-Codes/amrex#3585 there are two different IDs for every particle that are used incorrectly throughout hipace. This PR removes the old ID and replaces it with the new 39bit one. Note that the latest AMReX version is needed for this PR AMReX-Codes/amrex#3671 .

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the bug Something isn't working label Dec 12, 2023
@AlexanderSinn AlexanderSinn changed the title [WIP] Use 64 bit idcpu Use 64 bit idcpu Dec 15, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the fixes!!

@MaxThevenet MaxThevenet merged commit 09ec53b into Hi-PACE:development Dec 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants