Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are all parts of event types case sensitive? #30

Closed
garethsb opened this issue May 2, 2019 · 2 comments · Fixed by #47
Closed

Are all parts of event types case sensitive? #30

garethsb opened this issue May 2, 2019 · 2 comments · Fixed by #47
Labels
has PR Pull requests covering this entire issue have been opened

Comments

@garethsb
Copy link
Contributor

garethsb commented May 2, 2019

The documentation uses both "number/temperature/C" and "number/Temperature/C" as examples (differing just in the case of the initial letter of the measurement name element).

The regex for event type allows mixed case, but I haven't found any guidance in the specification as to whether event type names should be compared case-sensitive or not? Measurement units guidelines - Case sensitive behaviour only covers the units.

@garethsb garethsb changed the title Are event types case sensitive? Are all parts of event types case sensitive? May 2, 2019
@mjeras
Copy link
Collaborator

mjeras commented May 7, 2019

I would normally support case-insensitivity, but given that the SI units which are recommended are case sensitive, I think we should stick to case sensitivity and fix the documentation. @cristian-recoseanu , what do you think?

@andrewbonney
Copy link

I'd strongly recommend being case sensitive in these cases. It's very common for client applications to be written based upon an example implementation rather than by reading the spec, and as such making the assumption that you can simply test for string equality.

garethsb added a commit to garethsb/nmos-event-tally that referenced this issue May 16, 2019
@garethsb garethsb added the has PR Pull requests covering this entire issue have been opened label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR Pull requests covering this entire issue have been opened
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants