Fix some little typos... #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* capitalize 'REST', 'API', 'WebSocket', 'QoS', 'URL' and 'URI' consistently * use 'Events API' consistently to refer to the REST API * use back-ticks consistently e.g. to format JSON field names/examples within sentences * format JSON message examples more consistently * reduce use of 'will' and 'will be' to talk about the spec's defined behaviours, replacing with 'must' or, most often, just 'is' (there are still more...) * remove trailing double spaces (which force a break) where redundant
mjeras
reviewed
May 14, 2019
There was a problem hiding this comment.
Looks good to me, but it would be good for @cristian-recoseanu to have a look before merging as Cristian prepared the original documentation (I am ok with the schema changes)
Merged
|
Can we please go with "temperature" rather than "Temperature" |
garethsb
added a commit
that referenced
this pull request
May 21, 2019
….x, addressing review comment #44 (comment) to use lowercase 'temperature' in example event types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #40, and the 'number/Temperature' examples referred to in #30, and
If the above tweaks are too many, we can adjust the PR...