Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext_ transport params #48

Merged
merged 5 commits into from
May 21, 2019
Merged

Conversation

garethsb
Copy link
Contributor

Resolves #42.

This PR is on top of PR #44, so only commit 7ab1d45 is interesting.

Could add more examples, but I think this is enough to clarify things for implementers. The IS-07 test suite could be a better investment of time now!

garethsb added 5 commits May 14, 2019 13:45
* capitalize 'REST', 'API', 'WebSocket', 'QoS', 'URL' and 'URI' consistently
* use 'Events API' consistently to refer to the REST API
* use back-ticks consistently e.g. to format JSON field names/examples within sentences
* format JSON message examples more consistently
* reduce use of 'will' and 'will be' to talk about the spec's defined behaviours, replacing with 'must' or, most often, just 'is' (there are still more...)
* remove trailing double spaces (which force a break) where redundant
… for senders, and that the use of "auto" is not defined for the "ext_" parameters.
Copy link
Contributor

@mjeras mjeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mjeras mjeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garethsb garethsb merged commit 7ab1d45 into AMWA-TV:v1.0.x May 21, 2019
@garethsb garethsb deleted the ext-transport-params branch May 21, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify whether or not "auto" is allowed for IS-07 "ext_" transport parameters
2 participants