-
Notifications
You must be signed in to change notification settings - Fork 0
chore: sync Version.props from SDK #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ANcpLua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automated synchronization of dependency versions within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughVersion numbers updated for four NuGet packages in the Version.props configuration file: Roslyn.Utilities, Roslyn.Utilities.Sources, and Roslyn.Utilities.Testing bumped from 1.16.0 to 1.18.3; Analyzers updated from 1.9.0 to 1.10.2. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates centralized package version pins in Version.props to match the SDK-synced values.
Changes:
- Bump
ANcpLua.Roslyn.Utilities(runtime, sources, and testing) from1.16.0to1.18.3. - Bump
ANcpLua.Analyzersfrom1.9.0to1.10.2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request contains automated version updates for several dependencies, syncing them from the SDK. The changes appear correct and consistent with the goal of updating package versions. I have one suggestion to improve the maintainability of the Version.props file by reducing version number duplication.
| <PropertyGroup Label="Roslyn.Utilities"> | ||
| <ANcpLuaRoslynUtilitiesVersion>1.16.0</ANcpLuaRoslynUtilitiesVersion> | ||
| <ANcpLuaRoslynUtilitiesVersion>1.18.3</ANcpLuaRoslynUtilitiesVersion> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- ═══════════════════════════════════════════════════════════════════════ | ||
| ROSLYN.UTILITIES.SOURCES (Source-only package for generators) | ||
| ═══════════════════════════════════════════════════════════════════════ --> | ||
| <PropertyGroup Label="Roslyn.Utilities.Sources"> | ||
| <ANcpLuaRoslynUtilitiesSourcesVersion>1.16.0</ANcpLuaRoslynUtilitiesSourcesVersion> | ||
| <ANcpLuaRoslynUtilitiesSourcesVersion>1.18.3</ANcpLuaRoslynUtilitiesSourcesVersion> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- ═══════════════════════════════════════════════════════════════════════ | ||
| ROSLYN.UTILITIES.TESTING (Analyzer/CodeFix/Generator test infrastructure) | ||
| ═══════════════════════════════════════════════════════════════════════ --> | ||
| <PropertyGroup Label="Roslyn.Utilities.Testing"> | ||
| <ANcpLuaRoslynUtilitiesTestingVersion>1.16.0</ANcpLuaRoslynUtilitiesTestingVersion> | ||
| <ANcpLuaRoslynUtilitiesTestingVersion>1.18.3</ANcpLuaRoslynUtilitiesTestingVersion> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid duplicating the version number 1.18.3 across these related packages, consider defining a common version property and referencing it. This ensures they stay in sync and makes future updates easier. Note that since this file is auto-generated, this change might need to be applied to the source generation logic.
<PropertyGroup Label="Roslyn.Utilities">
<ANcpLuaRoslynUtilitiesFamilyVersion>1.18.3</ANcpLuaRoslynUtilitiesFamilyVersion>
<ANcpLuaRoslynUtilitiesVersion>$(ANcpLuaRoslynUtilitiesFamilyVersion)</ANcpLuaRoslynUtilitiesVersion>
</PropertyGroup>
<!-- ═══════════════════════════════════════════════════════════════════════
ROSLYN.UTILITIES.SOURCES (Source-only package for generators)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities.Sources">
<ANcpLuaRoslynUtilitiesSourcesVersion>$(ANcpLuaRoslynUtilitiesFamilyVersion)</ANcpLuaRoslynUtilitiesSourcesVersion>
</PropertyGroup>
<!-- ═══════════════════════════════════════════════════════════════════════
ROSLYN.UTILITIES.TESTING (Analyzer/CodeFix/Generator test infrastructure)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities.Testing">
<ANcpLuaRoslynUtilitiesTestingVersion>$(ANcpLuaRoslynUtilitiesFamilyVersion)</ANcpLuaRoslynUtilitiesTestingVersion>
</PropertyGroup>
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.