Skip to content

chore: sync Version.props from SDK #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ANcpLua wants to merge 1 commit into from
Closed

chore: sync Version.props from SDK #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Version.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,21 @@
ROSLYN.UTILITIES (Runtime package)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities">
<ANcpLuaRoslynUtilitiesVersion>1.16.0</ANcpLuaRoslynUtilitiesVersion>
<ANcpLuaRoslynUtilitiesVersion>1.18.3</ANcpLuaRoslynUtilitiesVersion>
</PropertyGroup>

<!-- ═══════════════════════════════════════════════════════════════════════
ROSLYN.UTILITIES.SOURCES (Source-only package for generators)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities.Sources">
<ANcpLuaRoslynUtilitiesSourcesVersion>1.16.0</ANcpLuaRoslynUtilitiesSourcesVersion>
<ANcpLuaRoslynUtilitiesSourcesVersion>1.18.3</ANcpLuaRoslynUtilitiesSourcesVersion>
</PropertyGroup>

<!-- ═══════════════════════════════════════════════════════════════════════
ROSLYN.UTILITIES.TESTING (Analyzer/CodeFix/Generator test infrastructure)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities.Testing">
<ANcpLuaRoslynUtilitiesTestingVersion>1.16.0</ANcpLuaRoslynUtilitiesTestingVersion>
<ANcpLuaRoslynUtilitiesTestingVersion>1.18.3</ANcpLuaRoslynUtilitiesTestingVersion>
</PropertyGroup>
Comment on lines 34 to 50
Copy link

@gemini-code-assist gemini-code-assist bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid duplicating the version number 1.18.3 across these related packages, consider defining a common version property and referencing it. This ensures they stay in sync and makes future updates easier. Note that since this file is auto-generated, this change might need to be applied to the source generation logic.

  <PropertyGroup Label="Roslyn.Utilities">
    <ANcpLuaRoslynUtilitiesFamilyVersion>1.18.3</ANcpLuaRoslynUtilitiesFamilyVersion>
    <ANcpLuaRoslynUtilitiesVersion>$(ANcpLuaRoslynUtilitiesFamilyVersion)</ANcpLuaRoslynUtilitiesVersion>
  </PropertyGroup>

  <!-- ═══════════════════════════════════════════════════════════════════════
       ROSLYN.UTILITIES.SOURCES (Source-only package for generators)
       ═══════════════════════════════════════════════════════════════════════ -->
  <PropertyGroup Label="Roslyn.Utilities.Sources">
    <ANcpLuaRoslynUtilitiesSourcesVersion>$(ANcpLuaRoslynUtilitiesFamilyVersion)</ANcpLuaRoslynUtilitiesSourcesVersion>
  </PropertyGroup>

  <!-- ═══════════════════════════════════════════════════════════════════════
       ROSLYN.UTILITIES.TESTING (Analyzer/CodeFix/Generator test infrastructure)
       ═══════════════════════════════════════════════════════════════════════ -->
  <PropertyGroup Label="Roslyn.Utilities.Testing">
    <ANcpLuaRoslynUtilitiesTestingVersion>$(ANcpLuaRoslynUtilitiesFamilyVersion)</ANcpLuaRoslynUtilitiesTestingVersion>
  </PropertyGroup>


<!-- ═══════════════════════════════════════════════════════════════════════
Expand Down Expand Up @@ -113,7 +113,7 @@
ANALYZERS (SDK-injected)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Analyzers">
<ANcpLuaAnalyzersVersion>1.9.0</ANcpLuaAnalyzersVersion>
<ANcpLuaAnalyzersVersion>1.10.2</ANcpLuaAnalyzersVersion>
<SbomTargetsVersion>4.1.5</SbomTargetsVersion>
<BannedApiAnalyzersVersion>3.3.4</BannedApiAnalyzersVersion>
<JonSkeetAnalyzersVersion>1.0.0-beta.6</JonSkeetAnalyzersVersion>
Expand Down