Update chrome driver url #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wllgrnt
force-pushed
the
will-update-chrome-driver-url
branch
3 times, most recently
from
a69d9c8
to
3f99e8d
Compare
wllgrnt
force-pushed
the
will-update-chrome-driver-url
branch
from
3f99e8d
to
12051a3
Compare
6 tasks
atzannes
reviewed
Sep 25, 2023
| echo "using chrome version $CHROME_MAIN_VERSION" | ||
| CHROMEDRIVER_VERSION=`curl -s "https://googlechromelabs.github.io/chrome-for-testing/LATEST_RELEASE_$CHROME_MAIN_VERSION"` | ||
| echo "using driver version $CHROMEDRIVER_VERSION" | ||
| curl "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/${CHROMEDRIVER_VERSION}/linux64/chromedriver-linux64.zip" -O |
There was a problem hiding this comment.
@wllgrnt That URL looks funky, almost like a CDN. Are we confident this will work long-term?
There was a problem hiding this comment.
It's from the https://googlechromelabs.github.io/chrome-for-testing/ dashboard - highly confident that those are the official urls, but nothing stopping them from changing it in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL we use in our build script no longer tracks version information for chrome versions > 114.0.5735
(June 2023) - updated to use the new recommended url, and added some prints to make debugging the curl error easier.
NB: this build still segfaulted when running the test suite.
Types of changes
Checklist: