ctrl+click opens new tab when using Clickable #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Elsewhere on the web ctrl+click will open whatever you click in a new tab, and for some usecases (e.g. testlooper) this would be useful to have in Cells - this PR adds that functionality. With thanks to @bokyoungkim-ap for pointers.
Approach
The changes on line 69 of Clickable.js are sufficient when the onClick function is standard and returning a string. When onClick is more complicated (e.g. check the object, make it if required, then link to it) you need the ctrlClick message.
How Has This Been Tested?
Ran on testlooper and clicked around + standard unit test battery.
Types of changes
Checklist: