Added conconcurrent testing #62
Conversation
|
This module (this patch) should follow the mbed style guideline. We should align it. Plus where is this test described what it does, what's expected output? |
|
@0xc0170 , I didn't know there was an mbed style guideline, can you point me to that? Also, where are we supposed to be documenting what the test is doing, and the expected output? Thanks. |
https://docs.mbed.com/docs/mbed-os-handbook/en/latest/cont/code_style/
I believe for this one we will need to start doing it. We got few cases in mbed OS where above the test case, we describe the test (what is testing) in the comments |
There was a problem hiding this comment.
@0xc0170 - this feature was requested by @screamerbg in issue #57
@brandonboesch - Tests need to be concurrent instead of sequential in the same test case as we discussed
…n seperate test cases. Still need to convert this to make them run concurrently in a single thread and in seperate threads.
…inish multi thread test case
brandonboesch
changed the title
| using namespace utest::v1; | ||
|
|
||
| volatile bool Result = false; | ||
|
|
There was a problem hiding this comment.
Need a check to see if AnalogIn is enabled before running this test
| Multi_Thread_ID = Thread::gettid(); // update thread id for this thread | ||
| Thread_I2C.start(callback(test_I2C)); // kick off threads | ||
| Thread_SPI.start(callback(test_SPI)); // kick off threads | ||
| wait(0.1); // allow time for debug print statements to complete. |
There was a problem hiding this comment.
Do you need this wait? Since it is waiting for threads to set their signal I do not believe you need the wait
There was a problem hiding this comment.
Yes, both threads could complete their work, and the test could exit before the debug print finishes its printing.
TESTS/concurrent/Mixed/Mixed.cpp
Outdated
| #error [NOT_SUPPORTED] I2C not supported on this platform, add 'DEVICE_I2C' definition to your platform. | ||
|
|
||
| #endif // !DEVICE_SPI or !DEVICE_I2C | ||
|
|
|
LGTM. @brandonboesch thanks for this! Please check @mray19027's comments. |
GPIO test runs DIO, AnalogIn, and InterruptIn sequentially in one test case.