Skip to content

Add ResetReason and Watchdog driver docs #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 11, 2019

Conversation

fkjagodzinski
Copy link
Member

@fkjagodzinski fkjagodzinski commented Jul 2, 2019

Add docs for the new drivers introduced in ARMmbed/mbed-os#10857.

This is mostly based on #404 (I wasn't able to cherry-pick these commits though). The ResetReason.md is unchanged. Watchdog.md is updated.

TODO:

  • update ResetReason class reference link,
  • update Watchdog class reference link.

@fkjagodzinski fkjagodzinski force-pushed the docs_update-watchdog branch from d754306 to 5f7929f Compare July 2, 2019 13:58
@fkjagodzinski
Copy link
Member Author

@AnotherButler I updated the docs as you requested. I hope they're OK now.

I'm not sure how the links (also listed in this PR's TODO) should be updated. Could you take care of that, please?

@AnotherButler
Copy link
Contributor

@fkjagodzinski Thanks for the updates. That's exactly what I was looking for. 👍

I'll update the links, but we have to wait until the code merges to master.

Amanda Butler added 2 commits July 3, 2019 09:55
Make minor tweaks.
Make minor copy edits, mostly for stylistic changes.
@AnotherButler
Copy link
Contributor

@0xc0170 Are you happy with this now?

Amanda Butler added 2 commits July 3, 2019 16:25
Fix Watchdog API reference link, so it points to correct Doxygen class.
Add link to .h file.

### ResetReason class reference

[![View code](https://www.mbed.com/embed/?type=library)](https://os.mbed.com/docs/mbed-os/development/mbed-os-api-doxy/_reset_reason_8h_source.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found the .h file in the Doxygen, but I can't find the class reference. I thought it would be here: https://os.mbed.com/docs/mbed-os/development/mbed-os-api-doxy/annotated.html but I don't see it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I can help here. Taking a Ticker class as an example, the v5.13 doxy can be found here:
https://os.mbed.com/docs/mbed-os/v5.13/mbed-os-api-doxy/classmbed_1_1_ticker.html

So I think we should expect ResetReason in NEW_DOCS_VERSION:
https://os.mbed.com/docs/mbed-os/NEW_DOCS_VERSION/mbed-os-api-doxy/classmbed_1_1_reset_reason.html
and Watchdog in:
https://os.mbed.com/docs/mbed-os/NEW_DOCS_VERSION/mbed-os-api-doxy/classmbed_1_1_watchdog.html

At least these are the filenames I get when generating the doxygen locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one for Watchdog is here: https://os.mbed.com/docs/mbed-os/development/mbed-os-api-doxy/classmbed_1_1_watchdog.html, but I can't find the one for ResetReason. There may be something wrong with the doxyfile_options files. @0xc0170 Can you help?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ARMmbed/mbed-os#10990 should fix this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That worked. 👍 Thanks for the PR.

Replace .h file transclusion with tranclusion of class reference.
@AnotherButler
Copy link
Contributor

@0xc0170 Are you happy with this?

@AnotherButler
Copy link
Contributor

Because the changes requested by @0xc0170 have been made and @0xc0170 is out and unable to click the "approve" button, I'm going to go ahead and merge this.

@AnotherButler AnotherButler merged commit 70064ed into ARMmbed:development Jul 11, 2019
@fkjagodzinski fkjagodzinski deleted the docs_update-watchdog branch July 12, 2019 08:17
AnotherButler pushed a commit that referenced this pull request Jul 16, 2019
Apply changes from PR #1099 to add content about the ResetReason driver to v5.13.
AnotherButler pushed a commit that referenced this pull request Jul 16, 2019
Add documentation for the Watchdog driver by applying changes from PR #1099 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants