Bring watchdog feature branch into master #10857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAL watchdog functionality will be implemented as two separate APIs. The reset reason API allows a user to detect the last system reset reason to identify if a Watchdog was triggered. The Watchdog API allows configuring and updating Watchdog timers on all boards. This commit defines the headers.
- Add preprocessor guard to watchdog api that errors if the reset reason api is not also implemented - Add RESET_REASON and WATCHDOG to K64F targets.json - Add watchdog reference implementation
- Fix typo in module comment - Redefine the default system behaviour in sleep mode - Guard K64F enableWait flag - Remove bit shifts from reset reason enum
- Change API to match C++ API throughout drivers - Amend HAL API documentation to be more specific
WDOG_Disable will suspend the watchdog until a reset is triggered instead of stopping it altogether. Deinit will disable it until it is reinitialized.
Limit MAX_TIMEOUT_MS to UINT32_MAX. Improve MAX_TIMEOUT_MS handling. Fix hal_watchdog_get_platform_features() returning .max_timeout = 0xfffffff8 instead of 0xffffffff.
Fix WATCHDOG_STATUS_INVALID_ARGUMENT for timeout values from 1 ms to 407 ms (fix inability to set prescaler bits to zero). Fix timeout <-> IWDG registers conversions. Fix read & write access to IWDG_PR and IWDG_RLR registers. Fix LSI RC frequency setting. Limit MAX_TIMEOUT_MS to UINT32_MAX.
Added a missing wait for the WCT window end. Without it, consecutive init() or stop() calls were ignored.
Relax time measurement margins for UBLOX_EVK_ODIN_W2.
Watchdog::stop() is called in this test. If the target does not support stopping the watchdog this case needs to be skipped. Also improve handling ignored test cases.
Use start method to set timeout
No config, neither additional parameter - the first instance of the class initalizes the peripheral.
Compare get_timeout against the last timeout successfully set. Merge most of the test cases into one. Do not rely on the tests execution order. Fix the watchdog_api_stub to keep timeout value set by init function.
We will provide documentation how to create your own VirtualWatchdog. It's simple, create timeout and watchdog objects. This class brought lot of discussion and questions. After our refactor we made this class just a linked list of objects - something tickers can do as well (they already have linked list) and handling hw should be done via Watchdog due to the limitations (timeout can be set only once per app!).
2 tasks
Updated docs are in ARMmbed/mbed-os-5-docs#1099. |
0xc0170
approved these changes
Jul 2, 2019
|
Started CI after the latest refactor Please review meanwhile |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
@bulislaw @donatieng Please review |
bulislaw
approved these changes
Jul 3, 2019
|
Picked manually , release label back. |
evedon
added
Manually Patch
release-version: 5.13.1
and removed
release-version: 5.13.1
Manually Patch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bring
feature-watchdogintomaster.Pull request type
Reviewers
@rajkan01 @donatieng @jamesbeyond @0xc0170
Release Notes
Adding new HAL API:
watchdogandreset_reasonAdding new drivers:
ResetReasonandWatchdogResetReason- checking the cause of the resetWatchdog- watchdog timer to reset the system