configs/*.json based configurations #140

JanneKiiskila · 2016-12-11T15:24:53Z

Per Marcelo Salazar's proposal add configuration examples to a configs-folder.
By default the repo does not anymore have an mbed_app.json at all, but one should
copy one of the example configs, potentially modify it and use it.

Jenkinsfile was modified to do the copy operation at the beginning.

Add the emac for UBLOX to Wifi configs.

Reference:
#137

JanneKiiskila · 2016-12-11T17:01:50Z

Quite doesn't work yet, as the mbed_app.json isn't there in all cases now.

cp mbed-client-ci-scripts/test_automation/security.h .
rm -rf mbed-client-ci-scripts
mbed ls -a
mbed-os-example-client (git@github.com:ARMmbed/mbed-os-example-client.git#da6c44002fae)
|- atmel-rf-driver (ssh://git@github.com/armmbed/atmel-rf-driver.git#62c0c49d7a94)
|- esp8266-driver (ssh://git@github.com/ARMmbed/esp8266-driver.git#86ed47c8bf40)
|- mbed-client (ssh://git@github.com/ARMmbed/mbed-client.git#92bdf6a69958)
| |- mbed-client-classic (ssh://git@github.com/ARMmbed/mbed-client-classic.git#42f18d977122)
| - mbed-client-mbed-tls (ssh://git@github.com/ARMmbed/mbed-client-mbed-tls.git#7e1b6d815038) |- mbed-os (ssh://git@github.com/ARMmbed/mbed-os.git#d5de476f74dd) |- mcr20a-rf-driver (ssh://git@github.com/ARMmbed/mcr20a-rf-driver.git#d8810e105d7d) - pal (ssh://git@github.com/ARMmbed/pal.git#4e46c0ea8706)
[ morpheus-wifi = morpheus ]
[ morpheus-wifi = morpheus-armcc ]
[ morpheus-wifi = morpheus-iar ]
[ morpheus-wifi = morpheus-wifi ]
sed -i -e s/ETHERNET/WIFI/g mbed_app.json
sed: can't read mbed_app.json: No such file or directory

@teetak or @kimlep need some help!

JanneKiiskila · 2016-12-11T19:10:50Z

Pulled back in the mbed_app.json to root, that sorted it. But we'd have to consolidate into something else in the future, I think. But, seems we have loads of different kinds of solutions now. Some are in Jenkins directly, some are in Jenkinsfile etc.

teetak01 · 2016-12-12T09:08:29Z

configs/eth_v4.json

+    "macros": ["MBEDTLS_USER_CONFIG_FILE=\"mbedtls_mbed_client_config.h\""],
+    "target_overrides": {
+        "*": {
+            "target.features_add": ["LWIP", "NANOSTACK", "COMMON_PAL"],


should not need nanostack

Unfortunately, it does! If one does NOT include Nanostack if fails:

jankii01@ubuntu:~/mbed/mbed-os-example-client$ ./build_all.sh
Building project mbed-os-example-client (K64F, GCC_ARM)
Scan: .
Scan: FEATURE_LWIP
Scan: FEATURE_UVISOR
Scan: FEATURE_COMMON_PAL
Scan: FEATURE_BLE
Scan: FEATURE_STORAGE
Scan: FEATURE_THREAD_BORDER_ROUTER
Scan: FEATURE_THREAD_ROUTER
Scan: FEATURE_LOWPAN_BORDER_ROUTER
Scan: FEATURE_LOWPAN_ROUTER
Scan: FEATURE_LOWPAN_HOST
Scan: FEATURE_NANOSTACK_FULL
Scan: FEATURE_NANOSTACK
Scan: FEATURE_THREAD_END_DEVICE
Scan: mbed
Scan: env
Compile [ 0.3%]: NanostackRfPhyAtmel.cpp
[ERROR] ./atmel-rf-driver/source/NanostackRfPhyAtmel.cpp:18:44: fatal error: nanostack/platform/arm_hal_phy.h: No such file or directory
compilation terminated.

-> it only works w/o NANOSTACK - IF YOU MOVE OUT THE other extra repos. This is due to the "compile all" nature of the mbed! If you move the extra RF-drivers to TARGET_IGNORE -folder, then it works. But that's another pain.

teetak01 · 2016-12-12T09:08:38Z

configs/eth_v6.json

+    "macros": ["MBEDTLS_USER_CONFIG_FILE=\"mbedtls_mbed_client_config.h\""],
+    "target_overrides": {
+        "*": {
+            "target.features_add": ["LWIP", "NANOSTACK", "COMMON_PAL"],


should not need nanostack

Unfortunately, does. Unless you start to move esp, atmel etc. out of the main folder..

teetak01 · 2016-12-12T09:09:02Z

configs/mesh_6lowpan.json

+    "macros": ["MBEDTLS_USER_CONFIG_FILE=\"mbedtls_mbed_client_config.h\""],
+    "target_overrides": {
+        "*": {
+            "target.features_add": ["LWIP", "NANOSTACK", "LOWPAN_ROUTER", "COMMON_PAL"],


LWIP not needed here

teetak01 · 2016-12-12T09:09:12Z

configs/mesh_thread.json

+    "macros": ["MBEDTLS_USER_CONFIG_FILE=\"mbedtls_mbed_client_config.h\""],
+    "target_overrides": {
+        "*": {
+            "target.features_add": ["LWIP", "NANOSTACK", "THREAD_ROUTER", "COMMON_PAL"],


LWIP not needed here

teetak01 · 2016-12-12T09:09:27Z

configs/mesh_thread.json

+            "mbed-mesh-api.thread-config-channel": 18,
+            "mbed-mesh-api.thread-config-panid": "0xBAAB",
+            "lwip.ipv4-enabled": false,
+            "lwip.ipv6-enabled": true,


lwip specifications not needed

teetak01 · 2016-12-12T09:11:22Z

configs/mbed_app.json

+            "wifi-rx": "PA_12"
+        }
+    }
+}


Is this file needed for something? It should be deleted INMO.

Instead the root folder should have minimal configuration for IPV4 LWIP as baseline. (So that the application will always build for something).

teetak01 · 2016-12-12T09:11:50Z

configs/wifi_v6.json

+    "macros": ["MBEDTLS_USER_CONFIG_FILE=\"mbedtls_mbed_client_config.h\""],
+    "target_overrides": {
+        "*": {
+            "target.features_add": ["NANOSTACK", "LOWPAN_ROUTER", "COMMON_PAL"],


nanostack not needed

teetak01 · 2016-12-12T09:12:14Z

Jenkinsfile

@@ -72,6 +72,9 @@ def buildStep(target, compilerLabel, toolchain, configName, connectiontype) {
        deleteDir()
        dir("mbed-os-example-client") {
          checkout scm
+          // Make us "backwards compatible" the easy way...
+          execute ("cp configs/example.json mbed_app.json")


not really needed. We instead need to have basic mbed_app.json in main folder.

I was thinking we shouldn't have any default mbed_app.json in the repo, but rather just copy always one and start from there. That way any potential sed -operations would not touch any trackable items and git operations can be a bit easier then.

kimlep01 · 2016-12-12T09:36:05Z

I am seeing SOCKET_MODE : TCP again with 6lowpan ( same as with #139 ).

Per Marcelo Salazar's proposal add configuration examples to a configs-folder. By default the repo does not anymore have an mbed_app.json at all, but one should copy one of the example configs, potentially modify it and use it. Jenkinsfile was modified to do the copy operation at the beginning. Add the emac for UBLOX to Wifi configs. Add mbedignore files to avoid the compilation problems. Reference: #137

Remove the LWIPs from those, remove the example.json and mbed_app.json under Configs -folder Add more builds for the build_all.sh.

Mesh-networking ONLY supports UDP, others support both. Table to illustrate this.

No need to copy the example.json, because we keep (for now at least) the mbed_app.json in the root.

The ``` needs to be on it's own line. Still a bit more tweaking on the UPD/TCP.

0xc0170 · 2016-12-13T12:37:34Z

configs/wifi_v6.json

+            "wifi-rx": "PA_12"
+        },
+        "UBLOX_EVK_ODIN_W2": {
+            "target.device_has": ["EMAC"]


EMAC is defined for ODIN by default

Copied that from the mbed-os-example-wifi, that's on also there.
To be removed from both, then?

Bigger issue seems to be our WiFi stacks don't support IPv6 at all?

I'll fix wifi example , here's a reference to targets.json file, you cna see EMAC there defined (wifi ON by default). https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L1310

Bigger issue seems to be our WiFi stacks don't support IPv6 at all?

has not been tested neither verified (some bits are missing there) thus for now, unsupported

Based on review comment - it is on by default for ODIN, no need to add it there (ref: Martin Kojtal).

0xc0170 · 2016-12-13T12:45:51Z

configs/wifi_v4.json

+            "wifi-rx": "PA_12"
+        },
+        "UBLOX_EVK_ODIN_W2": {
+            "target.device_has": ["EMAC"]


same here, EMAC defined by a target

Will remove it. And the whole wifi_v6.json.

Seems the WiFi stacks do not support IPv6 yet, so drop those from the build_all.sh. There were also some bad namings for binaries, so fixed those as well.

This reverts commit a9a3580.

JanneKiiskila force-pushed the conf branch 2 times, most recently from 6a931cc to 7056e64 Compare December 11, 2016 16:44

JanneKiiskila requested review from teetak01, TeroJaasko and kimlep01 December 11, 2016 17:03

JanneKiiskila force-pushed the conf branch from 7056e64 to ee42953 Compare December 11, 2016 17:05

teetak01 suggested changes Dec 12, 2016

View reviewed changes

JanneKiiskila force-pushed the conf branch from ee42953 to fd8779f Compare December 13, 2016 10:03

Janne Kiiskilä added 4 commits December 13, 2016 13:55

Changes per review comments for mesh configurations

54359e7

Remove the LWIPs from those, remove the example.json and mbed_app.json under Configs -folder Add more builds for the build_all.sh.

Clarify connection types per bearer

7b31540

Mesh-networking ONLY supports UDP, others support both. Table to illustrate this.

Remove Jenkinsfile hack

7e9b4b6

No need to copy the example.json, because we keep (for now at least) the mbed_app.json in the root.

Fix the markdown issue with the ipv4/ipv6 example

0a4bab8

The ``` needs to be on it's own line. Still a bit more tweaking on the UPD/TCP.

teetak01 approved these changes Dec 13, 2016

View reviewed changes

MarceloSalazar self-requested a review December 13, 2016 12:35

0xc0170 reviewed Dec 13, 2016

View reviewed changes

Remove ODIN EMAC from wifi_v4.json

1c6efdf

Based on review comment - it is on by default for ODIN, no need to add it there (ref: Martin Kojtal).

0xc0170 reviewed Dec 13, 2016

View reviewed changes

Indicate more clearly WiFi is not supported on IPv6

909b619

Seems the WiFi stacks do not support IPv6 yet, so drop those from the build_all.sh. There were also some bad namings for binaries, so fixed those as well.

JanneKiiskila merged commit a9a3580 into master Dec 13, 2016

JanneKiiskila deleted the conf branch December 13, 2016 13:34

JanneKiiskila pushed a commit that referenced this pull request Dec 14, 2016

Revert "configs/*.json based configurations (#140)"

733f705

This reverts commit a9a3580.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

configs/*.json based configurations #140

configs/*.json based configurations #140

JanneKiiskila commented Dec 11, 2016

JanneKiiskila commented Dec 11, 2016

JanneKiiskila commented Dec 11, 2016

teetak01 Dec 12, 2016

JanneKiiskila Dec 12, 2016

teetak01 Dec 12, 2016

JanneKiiskila Dec 12, 2016

teetak01 Dec 12, 2016

teetak01 Dec 12, 2016

teetak01 Dec 12, 2016

teetak01 Dec 12, 2016

teetak01 Dec 12, 2016

teetak01 Dec 12, 2016

JanneKiiskila Dec 13, 2016

kimlep01 commented Dec 12, 2016

0xc0170 Dec 13, 2016

JanneKiiskila Dec 13, 2016

JanneKiiskila Dec 13, 2016

0xc0170 Dec 13, 2016

0xc0170 Dec 13, 2016

0xc0170 Dec 13, 2016

JanneKiiskila Dec 13, 2016

configs/*.json based configurations #140

configs/*.json based configurations #140

Conversation

JanneKiiskila commented Dec 11, 2016

JanneKiiskila commented Dec 11, 2016

JanneKiiskila commented Dec 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kimlep01 commented Dec 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment