Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTB_STM_L475: fix UART clock #10156

Merged
merged 1 commit into from
Mar 21, 2019
Merged

MTB_STM_L475: fix UART clock #10156

merged 1 commit into from
Mar 21, 2019

Conversation

juhoeskeli
Copy link
Contributor

Description

Fix UART communications for MTB_STM_L475 by adjusting the UART system clock. Tested with various modem shields using the MCU. Without the change the MCU to modem communications will be corrupted.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ashok-rao

Release Notes

@ashok-rao
Copy link
Contributor

@0xc0170 : I have also validated this change with: https://github.com/ARMmbed/reference-design-RD2166

@ciarmcom ciarmcom requested review from ashok-rao, screamerbg and a team March 19, 2019 14:00
@ciarmcom
Copy link
Member

@juhoeskeli, thank you for your changes.
@ashok-rao @screamerbg @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @juhoeskeli

@@ -200,6 +201,7 @@ uint8_t SetSysClock_PLL_HSE(uint8_t bypass)
return 0; // FAIL
}

#if 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for leaving this block of code in if it's never going to be run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason. I'll take it out.

@cmonr
Copy link
Contributor

cmonr commented Mar 20, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 20, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit d850d3b into ARMmbed:master Mar 21, 2019
@juhoeskeli juhoeskeli deleted the MTB_STM_L475_uart_clock_fix branch March 21, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants