Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32H7: WATCHDOG and RESET_REASON support #10466

Merged
merged 5 commits into from
Jul 8, 2019
Merged

STM32H7: WATCHDOG and RESET_REASON support #10466

merged 5 commits into from
Jul 8, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

This PR enables the WATCHDOG and RESET_REASON feature support for STM32H7.

target platform_name test suite result elapsed_time (sec) copy_method
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_drivers-reset_reason OK 19.81 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_drivers-watchdog OK 20.21 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_drivers-watchdog_reset OK 21.99 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_hal-reset_reason OK 19.87 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_hal-watchdog OK 20.28 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_hal-watchdog_reset OK 22.36 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_hal-watchdog_timing OK 35.82 default

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team April 25, 2019 11:07
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@jeromecoutant
Copy link
Collaborator Author

Any review and CI ?
Thx

@0xc0170 0xc0170 requested a review from rajkan01 May 2, 2019 11:56
@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2019

Sorry for the delay, assigned for review,

I'll review shortly as well.

@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2019

@jeromecoutant Is this one also aligned with #10066 - 10066 update should go in first

@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2019 •
edited
Loading

As soon as watchdog branch is updated, astyle error should be resolved (travis regex to get astyle files was updated recently).

The error below is from targets file (should not be checked).

@adbridge
Copy link
Contributor

adbridge commented May 8, 2019

As soon as watchdog branch is updated, astyle error should be resolved (travis regex to get astyle files was updated recently).

What watchdog updates were we waiting for ?

@jeromecoutant
Copy link
Collaborator Author

What watchdog updates were we waiting for ?

#10066 ?

@adbridge
Copy link
Contributor

@donatieng another one for the watchdog list..

@jeromecoutant
Copy link
Collaborator Author

Hi
I suppose I will need to rebase after #10645 now ?

@0xc0170 0xc0170 force-pushed the feature-watchdog branch from 348e578 to f4e6966 Compare June 3, 2019 11:38
@jeromecoutant
Copy link
Collaborator Author

@fkjagodzinski maybe I should wait for #10857 now...

@adbridge adbridge removed the request for review from rajkan01 June 18, 2019 16:53
@jamesbeyond
Copy link
Contributor

Hi @jeromecoutant, we are planing to bring the watchdog feature branch to mbed-os master, would you able to wait for that, and make your PR to master ?

@fkjagodzinski
Copy link
Member

@jeromecoutant I'm sorry to keep you waiting with this PR. This patch looks OK for me, but it might be best to actually wait for #10857 being merged first. I'll keep an eye on it.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 25, 2019

@jeromecoutant I'm sorry to keep you waiting with this PR. This patch looks OK for me, but it might be best to actually wait for #10857 being merged first. I'll keep an eye on it.

@jeromecoutant hope it is OK, we are now focusing on 10857 to get in asap

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2019

Setting this as needs: work, once watchdog lands on master, redirect this to master

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

Ready for master, please update the branch and rebase

@jeromecoutant jeromecoutant force-pushed the PR_STM32H7_WATCHDOG branch from 060ad36 to 923be9e Compare July 5, 2019 13:09
@jeromecoutant jeromecoutant changed the base branch from feature-watchdog to master July 5, 2019 13:11
@jeromecoutant
Copy link
Collaborator Author

Rebase done.

Retest OK:

target platform_name test suite result elapsed_time (sec) copy_method
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_drivers-reset_reason OK 20.79 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_drivers-watchdog OK 19.66 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_drivers-watchdog_reset OK 22.32 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_hal-reset_reason OK 20.68 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_hal-rtc_reset OK 20.57 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_hal-watchdog OK 22.23 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_hal-watchdog_reset OK 22.4 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_hal-watchdog_timing OK 37.04 default
NUCLEO_H743ZI-ARMC6 NUCLEO_H743ZI tests-mbed_platform-system_reset OK 15.67 default

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 5, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@OPpuolitaival
Copy link
Contributor

Retriggering CI because testing CI changes

@mbed-ci
Copy link

mbed-ci commented Jul 8, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mbed-ci
Copy link

mbed-ci commented Jul 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit bd762ce into ARMmbed:master Jul 8, 2019
@jeromecoutant jeromecoutant deleted the PR_STM32H7_WATCHDOG branch July 8, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jeromecoutant @ciarmcom @0xc0170 @adbridge @jamesbeyond @fkjagodzinski @mbed-ci @OPpuolitaival @evedon