Add a gpio pinmap #10644

fkjagodzinski · 2019-05-23T12:51:18Z

Description

This is an alternative to #10459 -- instead of giving a list of pins to avoid, provide a list of pins that are suitable for all gpio tests.

This patch adds a gpio_pinmap() function that every target has to override to provide a set of pins for GPIO testing with the FPGA shield.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@c1728p9 @maclobdell @0xc0170 @maciejbocianski

Release Notes

Add a weak gpio_pinmap(), that every target has to override, to provide a set of pins for GPIO testing.

ciarmcom · 2019-05-23T13:00:36Z

@fkjagodzinski, thank you for your changes.
@maclobdell @maciejbocianski @MarceloSalazar @c1728p9 @0xc0170 @ARMmbed/mbed-os-test @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2019-05-23T13:04:58Z

This is consistent with the rest of pinmap API. On the other hand, there's a bit of ROM taken to hold the entire gpio table (some chips are large - have lot of pins).

@ARMmbed/mbed-os-hal Please review

c1728p9

I left some comments, but the change looks good to me. @0xc0170 the extra ROM usage should only be for testing, so even for large devices this shouldn't be a problem.

hal/mbed_gpio.c

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/TARGET_FRDM/PeripheralNames.h

c1728p9 · 2019-05-23T14:24:38Z

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/TARGET_FRDM/PeripheralPins.c

+    {PTE11, GPIO_E, 1},
+    {PTE12, GPIO_E, 1},
+    // {PTE24, GPIO_E, 1}, // fixed pull-up (for I2C)
+    // {PTE25, GPIO_E, 1}, // fixed pull-up (for I2C)


This only applies to the pull up/down tests right? If so is there a way the GPIO tests could run all its normal testing on these pins except the pull up/down test?

mbed-ci · 2019-05-23T23:15:41Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

0xc0170 · 2019-05-24T08:10:08Z

@fkjagodzinski Today is the day to complete this one :-)

This was unnecessary since all the pins may be used independently.

fkjagodzinski · 2019-05-24T14:42:28Z

I've updated the code as @c1728p9 suggested. This is ready for CI again.

0xc0170 · 2019-05-27T06:52:09Z

CI started

mbed-ci · 2019-05-27T09:13:08Z

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test
jenkins-ci/mbed-os-ci_exporter

0xc0170 · 2019-05-27T09:16:50Z

tests-mbed_hal-pinmap failures in tests - looks related to the changeset, please review

fkjagodzinski · 2019-05-27T13:15:49Z

Two targets failed tests-mbed_hal-pinmap / pinmap - validation because of NC pins present in the Arduino form factor:

mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_KW24D/TARGET_FRDM/PinNames.h

Line 103 in a4738fa

D4 = NC,

mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_KW41Z/TARGET_FRDM/PinNames.h

Line 103 in a4738fa

A0 = (int)0xFFFFFFFF,

I added a dedicated gpio_pinmap() for each of these targets.

fkjagodzinski · 2019-05-29T09:42:23Z

Ready to run CI tests again.

0xc0170 · 2019-05-30T14:37:50Z

CI started

mbed-ci · 2019-05-30T19:16:59Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

adbridge · 2019-06-20T14:39:05Z

@maciejbocianski could you please review the additional changes?

maciejbocianski

LGTM

mmahadevan108 · 2019-07-17T16:22:16Z

How was it decided what pins go into the PinMap_GPIO array for each supported Freescale platform?

fkjagodzinski · 2019-07-18T13:24:17Z

How was it decided what pins go into the PinMap_GPIO array for each supported Freescale platform?

I added pins based on the spec for each chip:
KW41Z -- MKW41Z512RM.pdf, section 2.2 Signal Multiplexing and Pin Assignments,
KW24D -- MKW2xDxxxRM.pdf, section 3.3 MKW2xD Pins,
K64F -- K64P144M120SF5RM.pdf, section 10.3.1 K64 Signal Multiplexing and Pin Assignments.

My intention was to add every possible pin, so we could later comment out any unsupported ones if needed.

Filip Jagodzinski added 3 commits May 23, 2019 14:29

Add HAL API for GPIO pinmap

a6eb48c

Add a sanity check for the GPIO pinmap

6e40546

K64F: Add a GPIO pinmap for testing

5bc8732

fkjagodzinski mentioned this pull request May 23, 2019

Exclude target-specific pins from GPIO tests with the FPGA shield #10459

Closed

ciarmcom requested review from 0xc0170, c1728p9, maciejbocianski, maclobdell, MarceloSalazar and a team May 23, 2019 13:00

ciarmcom added the needs: review label May 23, 2019

c1728p9 approved these changes May 23, 2019

View reviewed changes

Filip Jagodzinski added 2 commits May 24, 2019 16:33

K64F: Use a common peripheral name in GPIO pinmap

a326db8

This was unnecessary since all the pins may be used independently.

Provide a default gpio_pinmap() for arduino_ff

63fd9f9

maciejbocianski approved these changes May 27, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels May 27, 2019

Filip Jagodzinski added 2 commits May 27, 2019 13:21

KW24D: Add a GPIO pinmap for testing

1a9b635

KW41Z: Add a GPIO pinmap for testing

61f9a1c

0xc0170 added needs: CI and removed needs: work labels May 29, 2019

0xc0170 added needs: review release-version: 5.14.0-rc1 and removed needs: CI labels May 31, 2019

maciejbocianski approved these changes Jun 21, 2019

View reviewed changes

0xc0170 approved these changes Jul 11, 2019

View reviewed changes

fkjagodzinski mentioned this pull request Jul 12, 2019

Extend the GPIO HAL API tests #11038

Merged

SeppoTakalo added ready for merge and removed needs: review labels Jul 17, 2019

SeppoTakalo merged commit 3d5489a into ARMmbed:master Jul 17, 2019

SeppoTakalo removed the ready for merge label Jul 17, 2019

fkjagodzinski deleted the hal-gpio_pinmap branch July 17, 2019 11:41

fkjagodzinski mentioned this pull request Jul 19, 2019

Add a gpio-irq pinmap #11074

Merged

amq mentioned this pull request Feb 5, 2020

EFM32: pinmap test fails #12371

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a gpio pinmap #10644

Add a gpio pinmap #10644

fkjagodzinski commented May 23, 2019

ciarmcom commented May 23, 2019

0xc0170 commented May 23, 2019

c1728p9 left a comment

c1728p9 May 23, 2019

mbed-ci commented May 23, 2019

0xc0170 commented May 24, 2019

fkjagodzinski commented May 24, 2019

0xc0170 commented May 27, 2019

mbed-ci commented May 27, 2019

0xc0170 commented May 27, 2019

fkjagodzinski commented May 27, 2019 •

edited

Loading

fkjagodzinski commented May 29, 2019

0xc0170 commented May 30, 2019

mbed-ci commented May 30, 2019

adbridge commented Jun 20, 2019

maciejbocianski left a comment

mmahadevan108 commented Jul 17, 2019

fkjagodzinski commented Jul 18, 2019

Add a gpio pinmap #10644

Add a gpio pinmap #10644

Conversation

fkjagodzinski commented May 23, 2019

Description

Pull request type

Reviewers

Release Notes

ciarmcom commented May 23, 2019

0xc0170 commented May 23, 2019

c1728p9 left a comment

Choose a reason for hiding this comment

c1728p9 May 23, 2019

Choose a reason for hiding this comment

mbed-ci commented May 23, 2019

Test run: SUCCESS

0xc0170 commented May 24, 2019

fkjagodzinski commented May 24, 2019

0xc0170 commented May 27, 2019

mbed-ci commented May 27, 2019

Test run: FAILED

0xc0170 commented May 27, 2019

fkjagodzinski commented May 27, 2019 • edited Loading

fkjagodzinski commented May 29, 2019

0xc0170 commented May 30, 2019

mbed-ci commented May 30, 2019

Test run: SUCCESS

adbridge commented Jun 20, 2019

maciejbocianski left a comment

Choose a reason for hiding this comment

mmahadevan108 commented Jul 17, 2019

fkjagodzinski commented Jul 18, 2019

fkjagodzinski commented May 27, 2019 •

edited

Loading