fpga tests: clear uart fix #12052

yarbcy · 2019-12-09T11:23:12Z

Summary of changes

Clear UART events before enabling
Reset device before return from test case

Impact of changes

Migration actions required

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

CY8CKIT_062_WIFI_BT_FPGA.txt

target	platform_name	test suite	result	elapsed_time (sec)	copy_method
CY8CKIT_062_WIFI_BT-GCC_ARM	CY8CKIT_062_WIFI_BT	tests-mbed_hal_fpga_ci_test_shield-gpio	OK	28.29	default
CY8CKIT_062_WIFI_BT-GCC_ARM	CY8CKIT_062_WIFI_BT	tests-mbed_hal_fpga_ci_test_shield-gpio_irq	OK	27.04	default
CY8CKIT_062_WIFI_BT-GCC_ARM	CY8CKIT_062_WIFI_BT	tests-mbed_hal_fpga_ci_test_shield-i2c	OK	31.48	default
CY8CKIT_062_WIFI_BT-GCC_ARM	CY8CKIT_062_WIFI_BT	tests-mbed_hal_fpga_ci_test_shield-pwm	OK	74.84	default
CY8CKIT_062_WIFI_BT-GCC_ARM	CY8CKIT_062_WIFI_BT	tests-mbed_hal_fpga_ci_test_shield-spi	OK	34.02	default
CY8CKIT_062_WIFI_BT-GCC_ARM	CY8CKIT_062_WIFI_BT	tests-mbed_hal_fpga_ci_test_shield-uart	OK	35.87	default
mbedgt: test suite results: 6 OK

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

1. Clear UART events before enabling 2. Reset device before return from test case

yarbcy · 2019-12-09T11:24:41Z

@mprse @0xc0170 Please review.

ciarmcom · 2019-12-09T12:00:36Z

@yarbcy, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

yarbcy · 2019-12-09T13:27:27Z

@0xc0170 Please update CI.

TESTS/mbed_hal_fpga_ci_test_shield/uart/main.cpp

mprse

Approved. Well done!

mprse · 2019-12-10T08:42:06Z

Since tests-mbed_hal_fpga_ci_test_shield-uart is modified by this PR we should also check if the test still passes on other CI targets (if FPGA tests are not executed during CI).

yarbcy · 2019-12-10T08:49:44Z

Since tests-mbed_hal_fpga_ci_test_shield-uart is modified by this PR we should also check if the test still passes on other CI targets (if FPGA tests are not executed during CI).
@mprse
Who can run it? I have only Cypress targets.

mprse · 2019-12-10T09:10:39Z

Who can run it?

I can do that but probably not today,

mprse · 2019-12-10T14:01:26Z

| target       | platform_name | test suite                              | test case                              | passed | failed | result | elapsed_time (sec) |
|--------------|---------------|-----------------------------------------|----------------------------------------|--------|--------|--------|--------------------|
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 115200, 8N1, FC off                    | 1      | 0      | OK     | 0.23               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 115200, 8N1, FC on                     | 1      | 0      | OK     | 0.25               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 19200, 8N1, FC off                     | 1      | 0      | OK     | 0.25               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 19200, 8N1, FC on                      | 1      | 0      | OK     | 0.26               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 38400, 8N1, FC off                     | 1      | 0      | OK     | 0.25               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 38400, 8N1, FC on                      | 1      | 0      | OK     | 0.27               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 9600, 8E1, FC on                       | 1      | 0      | OK     | 0.31               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 9600, 8N2, FC off                      | 1      | 0      | OK     | 0.3                |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 9600, 8N2, FC on                       | 1      | 0      | OK     | 0.32               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | 9600, 8O1, FC on                       | 1      | 0      | OK     | 0.32               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | basic (direct init), 9600, 8N1, FC off | 1      | 0      | OK     | 0.9                |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | basic (direct init), 9600, 8N1, FC on  | 1      | 0      | OK     | 0.5                |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | basic, 9600, 8N1, FC off               | 1      | 0      | OK     | 0.89               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | basic, 9600, 8N1, FC on                | 1      | 0      | OK     | 0.49               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | init/free, FC off                      | 1      | 0      | OK     | 0.86               |
| K64F-GCC_ARM | K64F          | tests-mbed_hal_fpga_ci_test_shield-uart | init/free, FC on                       | 1      | 0      | OK     | 1.18               |

| target                | platform_name | test suite                              | test case                              | passed | failed | result | elapsed_time (sec) |
|-----------------------|---------------|-----------------------------------------|----------------------------------------|--------|--------|--------|--------------------|
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 115200, 8N1, FC off                    | 1      | 0      | OK     | 0.22               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 115200, 8N1, FC on                     | 1      | 0      | OK     | 0.13               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 19200, 8N1, FC off                     | 1      | 0      | OK     | 0.25               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 19200, 8N1, FC on                      | 1      | 0      | OK     | 0.12               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 38400, 8N1, FC off                     | 1      | 0      | OK     | 0.23               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 38400, 8N1, FC on                      | 1      | 0      | OK     | 0.13               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 9600, 8E1, FC on                       | 1      | 0      | OK     | 0.14               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 9600, 8N2, FC off                      | 1      | 0      | OK     | 0.29               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 9600, 8N2, FC on                       | 1      | 0      | OK     | 0.12               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | 9600, 8O1, FC on                       | 1      | 0      | OK     | 0.12               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | basic (direct init), 9600, 8N1, FC off | 1      | 0      | OK     | 0.35               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | basic (direct init), 9600, 8N1, FC on  | 1      | 0      | OK     | 0.21               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | basic, 9600, 8N1, FC off               | 1      | 0      | OK     | 0.34               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | basic, 9600, 8N1, FC on                | 1      | 0      | OK     | 0.2                |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | init/free, FC off                      | 1      | 0      | OK     | 0.32               |
| NUCLEO_F429ZI-GCC_ARM | NUCLEO_F429ZI | tests-mbed_hal_fpga_ci_test_shield-uart | init/free, FC on                       | 1      | 0      | OK     | 0.25               |

yarbcy · 2019-12-10T16:09:15Z

@0xc0170 @adbridge Please update CI.

0xc0170 · 2019-12-10T16:33:09Z

@yarbcy set ready for CI , we just need to complete 5.15rc2 today , might run later tonight

fkjagodzinski

Thanks for the fix. 👍

The code is fine but the commit message references the wrong issue number. Should be #11860 instead of #11859. @0xc0170, I'm not sure how important this might be.

mbed-ci · 2019-12-10T19:17:35Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

0xc0170 · 2019-12-11T07:06:51Z

@yarbcy PR title shall contain a module name and what it fixes. This title is used in the release notes.
I edited it and added correct issue number to the merge commit.

Thanks!

adbridge · 2020-04-02T16:40:09Z

@Mergifyio backport mbed-os-5.15

mergify · 2020-04-02T18:10:46Z

Command backport mbed-os-5.15: failure

No backport have been created

Backport to branch mbed-os-5.15 failed

1. Clear UART events before enabling 2. Reset device before return from test case

* upstream/mbed-os-5.15: (45 commits) Revert "Backport ARMmbed#12603: Add CYSBSYSKIT_01" Update STM32 EMAC driver based on review Update STM32 EMAC driver - limit RX frame length WHD: Remove an assert from get_rssi() crypto: Use updated ECC curve macros crypto: Update the service for Mbed Crypto 3.x crypto: Upgrade to Mbed Crypto 3.1.0 tls: Upgrade to Mbed TLS 2.20.0 Backport ARMmbed#12701: Custom BT Firmware for CYW9P62S1_43012EVB_01 Backport ARMmbed#12603: Add CYSBSYSKIT_01 Backport ARMmbed#12492: Update psoc6cm0p to version 1.1.1. Backport ARMmbed#12422: Cypress Asset Update Backport ARMmbed#12421: Cypress target reorganization Backport ARMmbed#12394: Fix Cypress 1M SDIO + other minor bugs Backport ARMmbed#12097: Cypress: Fix IAR Warnings Backport ARMmbed#12052: Fix for ARM issue 11859. Backport ARMmbed#12038: Remove qspi_frequency() call. Backport ARMmbed#12019: rework cypress lptimer hal Cellular: ALT1250 PPP cellular driver for mbed-os 5.15 RZ_A1H and GR_LYCHEE: Enable bootloader support (Mbed OS 5.15) ...

Fix for ARM issue 11859.

a79b1b3

1. Clear UART events before enabling 2. Reset device before return from test case

yarbcy mentioned this pull request Dec 9, 2019

Cypress: FPGA: UART random failure #11860

Closed

ciarmcom requested review from maclobdell and a team December 9, 2019 12:00

ciarmcom added the needs: review label Dec 9, 2019

0xc0170 added the devices: cypress label Dec 9, 2019

mprse reviewed Dec 9, 2019

View reviewed changes

TESTS/mbed_hal_fpga_ci_test_shield/uart/main.cpp Show resolved Hide resolved

mprse approved these changes Dec 9, 2019

View reviewed changes

0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Dec 10, 2019

0xc0170 approved these changes Dec 10, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Dec 10, 2019

fkjagodzinski approved these changes Dec 10, 2019

View reviewed changes

0xc0170 changed the title ~~Fix for ARM issue 11859.~~ fpga tests: clear uart fix Dec 11, 2019

0xc0170 merged commit f270146 into ARMmbed:master Dec 11, 2019

0xc0170 removed the needs: CI label Dec 11, 2019

yarbcy deleted the pr/fix-for-arm-issue-11860 branch December 11, 2019 14:00

adbridge added the Backport Candidate label Apr 2, 2020

kyle-cypress pushed a commit to kyle-cypress/mbed-os that referenced this pull request Apr 2, 2020

Backport ARMmbed#12052: Fix for ARM issue 11859.

738ec19

1. Clear UART events before enabling 2. Reset device before return from test case

kyle-cypress mentioned this pull request Apr 2, 2020

Cypress: Backport PRs from 6.0 to 5.15.2 #12753

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fpga tests: clear uart fix #12052

fpga tests: clear uart fix #12052

yarbcy commented Dec 9, 2019

yarbcy commented Dec 9, 2019

ciarmcom commented Dec 9, 2019

yarbcy commented Dec 9, 2019

mprse left a comment

mprse commented Dec 10, 2019

yarbcy commented Dec 10, 2019

mprse commented Dec 10, 2019

mprse commented Dec 10, 2019 •

edited

Loading

yarbcy commented Dec 10, 2019

0xc0170 commented Dec 10, 2019

fkjagodzinski left a comment

mbed-ci commented Dec 10, 2019

0xc0170 commented Dec 11, 2019 •

edited

Loading

adbridge commented Apr 2, 2020

mergify bot commented Apr 2, 2020

fpga tests: clear uart fix #12052

fpga tests: clear uart fix #12052

Conversation

yarbcy commented Dec 9, 2019

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

yarbcy commented Dec 9, 2019

ciarmcom commented Dec 9, 2019

yarbcy commented Dec 9, 2019

mprse left a comment

Choose a reason for hiding this comment

mprse commented Dec 10, 2019

yarbcy commented Dec 10, 2019

mprse commented Dec 10, 2019

mprse commented Dec 10, 2019 • edited Loading

yarbcy commented Dec 10, 2019

0xc0170 commented Dec 10, 2019

fkjagodzinski left a comment

Choose a reason for hiding this comment

mbed-ci commented Dec 10, 2019

Test run: SUCCESS

0xc0170 commented Dec 11, 2019 • edited Loading

adbridge commented Apr 2, 2020

mergify bot commented Apr 2, 2020

mprse commented Dec 10, 2019 •

edited

Loading

0xc0170 commented Dec 11, 2019 •

edited

Loading