Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDIO communication issue on Cypress 1M boards and other minor fixes #12394

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Fix SDIO communication issue on Cypress 1M boards and other minor fixes #12394

merged 3 commits into from
Feb 10, 2020

Conversation

miteshdedhia7
Copy link

@miteshdedhia7 miteshdedhia7 commented Feb 7, 2020 •
edited
Loading

Summary of changes

  • Added a multiply by 2 in the SDIO clock divider calculation to account for internal UDB divider. This fixes intermittent SDIO communication issues where the DMA engine would overflow the SDIO FIFO, causing bytes to be dropped.
  • Add missing error checks for emac power up. Prevents a crash when errors occur during power up.
  • Remove wounding for the hardware CRYPTO block. The PSoC 6 MPN in CYW9P62S1_43012EVB_01 was revised to add the hardware crypto block.

Impact of changes

Fixed issues with intermittent SDIO related WiFi firmware load failures on CY8CKIT_062_WIFI_BT, CYW943012P6EVB_01, CYW9P62S1_43012EVB_01, CYW9P62S1_43438EVB_01.

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

CY8CKIT_062_BLE-GCC_ARM.txt
CY8CKIT_062_WIFI_BT-GCC_ARM.txt
CY8CKIT_062S2_43012-GCC.txt
CY8CPROTO_062S3_4343W-GCC_ARM.txt
CY8CPROTO_063_BLE-GCC_ARM.txt
CYW9P62S1_43012EVB_01-GCC_ARM.txt
CYW9P62S1_43438EVB_01-GCC_ARM.txt
CYW943012P6EVB_01-GCC_ARM.txt

Test failures and explanations:

  • The pinmap test failure on the CYW9P6S21_43012EVB_01 is caused because 2 of the ARDUINO pins on that board are not connected. This is being evaluated for proper resolution in a future PR.
  • All sleep failures are expected due to to a known incompatibility between the sleep tests and our UART driver.
[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@morser499 @maclobdell

@cypress-midd
Remove wounding for the hardware CRYPTO block. The PSoC 6 MPN CYW9P62…
8a986f7 
…S1_43012EVB_01 was revised to add the hardware crypto block.
@cypress-midd
Add missing error checks for emac power up.
5f496a6
@cypress-midd
Added a multiplied by 2 in the SDIO clock divider calculation to acco…
df5ac64 
…unt for internal UDB divider.

Note: Fixes issues with intermittent WiFi firmware load failures on CY8CKIT_062_WIFI_BT, CYW943012P6EVB_01, CYW9P62S1_43012EVB_01, CYW9P62S1_43438EVB_01.
@mergify mergify bot added the needs: work label Feb 7, 2020
@ciarmcom ciarmcom requested review from maclobdell, morser499 and a team February 7, 2020 20:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 7, 2020

@miteshdedhia7, thank you for your changes.
@morser499 @maclobdell @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-ipcore please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 10, 2020
@0xc0170 0xc0170 added devices: cypress release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 labels Feb 10, 2020
0xc0170
0xc0170 approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference: please style changes separately. The commit df5ac64 contains one line fix but around hundreds styling changes (good to have these fixed, just should be separate commit at least).

The commit msg should be within 50 char (first line), second paragraph wider (see how it wraps here on Github).

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 10, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 10, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 88438df into ARMmbed:master Feb 10, 2020
@mergify mergify bot removed the ready for merge label Feb 10, 2020
@adbridge
Copy link
Contributor

adbridge commented Apr 2, 2020

@Mergifyio backport mbed-os-5.15

@mergify
Copy link

mergify bot commented Apr 2, 2020

Command backport mbed-os-5.15: failure

No backport have been created

  • Backport to branch mbed-os-5.15 failed

kyle-cypress pushed a commit to kyle-cypress/mbed-os that referenced this pull request Apr 2, 2020
@cypress-midd
Backport ARMmbed#12394: Fix Cypress 1M SDIO + other minor bugs
8199e25 
- Remove wounding for the hardware CRYPTO block. The PSoC 6 MPN CYW9P62S1_43012EVB_01 was revised
  to add the hardware crypto block.
- Add missing error checks for emac power up.
- Add a multiplied by 2 in the SDIO clock divider calculation to account for internal UDB divider.
  Note: Fixes issues with intermittent WiFi firmware load failures on CY8CKIT_062_WIFI_BT,
  CYW943012P6EVB_01, CYW9P62S1_43012EVB_01, CYW9P62S1_43438EVB_01.
@kyle-cypress kyle-cypress mentioned this pull request Apr 2, 2020
Merged
artokin pushed a commit to artokin/mbed-os that referenced this pull request Apr 16, 2020
Merge remote-tracking branch 'upstream/mbed-os-5.15' into feature-wisun
190eb9a 
* upstream/mbed-os-5.15: (45 commits)
  Revert "Backport ARMmbed#12603: Add CYSBSYSKIT_01"
  Update STM32 EMAC driver based on review
  Update STM32 EMAC driver - limit RX frame length
  WHD: Remove an assert from get_rssi()
  crypto: Use updated ECC curve macros
  crypto: Update the service for Mbed Crypto 3.x
  crypto: Upgrade to Mbed Crypto 3.1.0
  tls: Upgrade to Mbed TLS 2.20.0
  Backport ARMmbed#12701: Custom BT Firmware for CYW9P62S1_43012EVB_01
  Backport ARMmbed#12603: Add CYSBSYSKIT_01
  Backport ARMmbed#12492: Update psoc6cm0p to version 1.1.1.
  Backport ARMmbed#12422: Cypress Asset Update
  Backport ARMmbed#12421: Cypress target reorganization
  Backport ARMmbed#12394: Fix Cypress 1M SDIO + other minor bugs
  Backport ARMmbed#12097: Cypress: Fix IAR Warnings
  Backport ARMmbed#12052: Fix for ARM issue 11859.
  Backport ARMmbed#12038: Remove qspi_frequency() call.
  Backport ARMmbed#12019: rework cypress lptimer hal
  Cellular: ALT1250 PPP cellular driver for mbed-os 5.15
  RZ_A1H and GR_LYCHEE: Enable bootloader support (Mbed OS 5.15)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@bulislaw bulislaw bulislaw approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

@morser499 morser499 Awaiting requested review from morser499

Assignees
No one assigned
Labels
Backport Candidate devices: cypress release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@miteshdedhia7 @ciarmcom @0xc0170 @mbed-ci @adbridge @bulislaw @cypress-midd