STM32 : enable MBED trace for QSPI

[jeromecoutant]

Summary of changes

Goal is to enable mbed trace within QSPI STM32 file.

    "target_overrides": {
        "*": {
            "mbed-trace.enable": "1",

Impact of changes

Migration actions required

Documentation

---

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

---

[0xc0170]

A check - Isn't this similar to the commit that was part of another PR and broke mbed 2 build?

[jeromecoutant]

A check - Isn't this similar to the commit that was part of another PR and broke mbed 2 build?

Yes, same (except one word in a comment I think)

Let's see

[0xc0170]

As result, this fail mbed 2 tests in PRs , won't it ? The best is to wait until we complete baremetal feature, there are still couple of things to finish there - this will allow us to remove mbed 2 CI check. Until then, we should keep the code compatible.

cc @bulislaw

[VeijoPesonen]

"The group name length is limited to four characters." - https://github.com/ARMmbed/mbed-trace#compromises

[jeromecoutant]

Oh...
I will correct.

PS: I suggest you a "git grep TRACE_GROUP".... :-(

[ciarmcom]

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

[bulislaw]

Mbed 2 is gone (even if not yet removed) on master (feeding into 6) so we shouldn't test it.

[0xc0170]

CI started

[mbed-ci]

Test run: FAILED

Summary: 3 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_mbed2-build-ARM
• jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
• jenkins-ci/mbed-os-ci_mbed2-build-IAR

[jeromecoutant]

CI started

Could you try again ?

Thx

[0xc0170]

CI restarted

[0xc0170]

Ci did not report back, restarted

[mbed-ci]

Test run: SUCCESS

Summary: 8 of 8 test jobs passed
Build number : 3
Build artifacts

[jeromecoutant]

NB: difference between "test failed" commit, and "test success" commit:

#include "mbed_trace.h"
=> MBED2 build failed

#include "mbed-trace/mbed_trace.h"
=> all OK

[0xc0170]

I don't understand this then, looks like a bug in tools

[VeijoPesonen]

NB: difference between "test failed" commit, and "test success" commit:

#include "mbed_trace.h"
=> MBED2 build failed

#include "mbed-trace/mbed_trace.h"
=> all OK

I have stumbled on this same issue myself - #12270 (comment)