HAL: Add a get_capabilities() function to GPIO API #12477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 19, 2020 18:28
Add the gpio_get_capabilities() to GPIO HAL API. Add a default, weak implementation, that every target can override.
Make use of the gpio_get_capabilities() function to skip unsupported input pull modes when testing with the FPGA-CI-test-shield.
Remove the gpio_pinmap() for this target. GPIO tests are skipped based on pin's capabilities.
TARGET_NANO100, TARGET_NUC472 & TARGET_M451 do not support input pull mode configuration.
ciarmcom
requested review from
ccli8,
jamesbeyond,
maclobdell,
mprse,
Ronny-Liu,
wajahat-abbas and
a team
|
@fkjagodzinski, thank you for your changes. |
@fkjagodzinski Thanks for your reminding. That's fine. |
ccli8
approved these changes
Feb 21, 2020
mprse
approved these changes
Feb 21, 2020
0xc0170
approved these changes
Feb 21, 2020
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
That would be great. This is otherwise ready. Let us know how was this tested |
|
|
And in case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add the
gpio_get_capabilities()function to the GPIO HAL API to skip the unsupported input pull modes when testing with the FPGA-CI-test-shield.Updated tests:
tests-mbed_hal_fpga_ci_test_shield-gpio.Impact of changes
Extend the GPIO HAL API with the
gpio_get_capabilities()function. Unsupported input pull modes are skipped during the greentea tests.Migration actions required
A default, weak implementation is provided. Every target has to override this weak implementation to provide the correct
gpio_capabilities_t.Documentation
None
Pull request type
Test results
Reviewers
@ccli8, @wajahat-ublox, @mprse, @jamesbeyond