-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: update usb tests and guard them with macro #12498
Conversation
FYI @ARMmbed/team-st-mcd |
@@ -863,3 +865,4 @@ void USBEndpointTester::start_ep_in_abort_test() | |||
write_start(_endpoints[EP_INT_IN], _endpoint_buffs[EP_INT_IN], (*_endpoint_configs)[EP_INT_IN].max_packet); | |||
} | |||
#endif | |||
#endif //USB_DEVICE_TESTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lack of new line at the file end, Applies to all files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@jamesbeyond, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the missing new line at the end of the line.
Is this "exclude" the way we want to use? greentea does not support something similar to --exclude usb-*
- wouldn't this be preferable ?
Pull request has been modified.
Fixed, Could you remind why we need this empty line? @0xc0170, I remember it is in the contributions requirement, but can't recall why
Greentea has an excluding method. but it command line will end up too long if we excluding too many things. |
at least uvision prints a warning , and possibly some other but dont recall any other. We always keep one line empty since the beginning. |
CI started |
Test run: SUCCESSSummary: 5 of 5 test jobs passed |
Summary of changes
Some feedback we received recently: the USB devices tests are quite different from the rest of the greentea tests.
So we decided to guard those tests with a macro. when silicon partners want to port the USB devices, he will need to follow the README instructions. and then run the tests.
Impact of changes
Migration actions required
Documentation
Updates included
Pull request type
Test results
Reviewers
@MarceloSalazar @fkjagodzinski @maciejbocianski