Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix for STM32F4 hardfault in sleep mode #12717

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Add fix for STM32F4 hardfault in sleep mode #12717

merged 2 commits into from
Apr 8, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Mar 30, 2020 •
edited
Loading

Summary of changes

Same fix as for Mbed OS 6.0.0-beta1, #12662. Cherry-picked for Mbed OS 5.15.2.

This fix follows what https://www.st.com/resource/en/errata_sheet/dm00037591-stm32f405-407xx-and-stm32f415-417xx-device-limitations-stmicroelectronics.pdf errata states.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@MarceloSalazar @artokin

@0xc0170 0xc0170 mentioned this pull request Mar 30, 2020
Merged
@MarceloSalazar MarceloSalazar self-requested a review March 30, 2020 13:43
@mergify mergify bot added the needs: CI label Mar 30, 2020
@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 30, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 30, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 30, 2020

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest
  • jenkins-ci/mbed-os-ci_greentea-test

@jeromecoutant
Copy link
Collaborator

You should merge #12498 in 5.15 branch ?

@JanneKiiskila
Copy link
Contributor

@neilwjackson @adbridge @bulislaw - we need this to 5.15.2!

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 2, 2020

You should merge #12498 in 5.15 branch ?

I don't think so, we run different CI setup, I'll fix it now, start a new job and clear the old one

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 2, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: work labels Apr 2, 2020
@0xc0170 0xc0170 requested review from adbridge and bulislaw April 2, 2020 09:00
@bulislaw
Copy link
Member

bulislaw commented Apr 2, 2020

Please include it in 5.15.2

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 2, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM-lts
  • jenkins-ci/mbed-os-ci_build-ARM-lts

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 6, 2020

CI did not complete all green, will need a new job

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 6, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 7, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 7, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@mbed-ci
Copy link

mbed-ci commented Apr 7, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM-lts
  • jenkins-ci/mbed-os-ci_build-GCC_ARM-lts

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 7, 2020

The last run could be ignored (auto run was misconfigured), but example test - I'll look at this one

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 7, 2020

example test restarted

@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 7, 2020

@ARMmbed/mbed-os-test Have you seen this error previously:

[1586260863.02][CONN][RXD] --- Mbed OS filesystem example ---
[1586260863.02][CONN][RXD] Mounting the filesystem... OK
[1586260863.02][CONN][RXD] Opening "/fs/numbers.txt"... OK
[1586260863.02][CONN][RXD] 
Incrementing numbers (0/10)... 
Incrementing numbers (1/10)... 
Incrementing numbers (2/10)... 
Incrementing numbers (3/10)... 
Incrementing numbers (4/10)... 
Incrementing numbers (5/10)... 
Incrementing numbers (6/10)... 
Incrementing numbers (7/10)... 
Incrementing numbers (8/10)... 
Incrementing numbers (9/10)...
[1586260863.02][CONN][RXD]
[1586260863.02][CONN][RXD] ++ MbedOS Error Info ++
[1586260863.02][CONN][RXD] Error Status: 0x80FF0100 Code: 256 Module: 255
[1586260863.02][CONN][RXD] Error Message: Fatal Run-time error
[1586260863.02][CONN][RXD] Location: 0x1D8F
[1586260863.02][CONN][RXD] Error Value: 0x0
[1586260863.02][CONN][RXD] Current Thread: main Id: 0x2000231C Entry: 0x913F StackSize: 0x1000 StackMem: 0x20003660 SP: 0x200045A0
[1586260863.09][CONN][RXD] For more info, visit: https://mbed.com/s/error?error=0x80FF0100&tgt=K64F
[1586260863.09][CONN][RXD] -- MbedOS Error Info --
[1586260863.09][CONN][RXD] error: Success (0)

example file system failing for K64F - it's not related to this PR, have not seen it in other so far.

@mbed-ci
Copy link

mbed-ci commented Apr 8, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

@0xc0170 0xc0170 merged commit 82fc228 into ARMmbed:mbed-os-5.15 Apr 8, 2020
@mergify mergify bot removed the ready for merge label Apr 8, 2020
@JanneKiiskila JanneKiiskila mentioned this pull request Apr 8, 2020
Closed
@mak22223 mak22223 mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@MarceloSalazar MarceloSalazar MarceloSalazar approved these changes

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@0xc0170 @mbed-ci @jeromecoutant @JanneKiiskila @bulislaw @MarceloSalazar @adbridge @teetak01