Reverting #12312 as it breaking current WiFI connect()->Disconnect() sequence

[cy-arsm]

This reverts commit 18285e1.

Summary of changes

Issue:
In disconnect sequence, whd_emac_wifi_link_state_changed(FALSE) is called which is an asynchronous operation and execution is handled in tcp_ip thread(). As part of this api, it access the interface structure.
remove_ethernet_interface will remove the interface from the netif list, this is a synchronous execution and called after whd_emac_wifi_link_state_changed().
Hence there is synchronization issue, where whd_emac_wifi_link_state_changed() is trying to access the interface structure which is already freed by remove_ehternet_interface(). Hence crash is seen.

Hence reverting the remove interface in SoftAP->stop() and STA->disconnect() as it breaking the current WiFi connect()->disconnect() sequence.

Impact of changes

Migration actions required

Documentation

---

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

---

[ciarmcom]

@cy-arsm, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

[0xc0170]

Would it be worth adding a reason for the revert (using --edit when reverting), same that is here in description ?

[0xc0170]

Not only title, but also commit message. git revert provides an option --edit to do so, worth having in the message.

[cy-arsm]

@morser499 can you review the changes. Have reverted back the remove_ethernet_interface logic

[0xc0170]

CI started meanwhile

[mbed-ci]

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_build-IAR

[0xc0170]

CI restarted, internal fault

[mbed-ci]

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_exporter

[0xc0170]

@ARMmbed/mbed-os-ipcore Is this fine to go in?

[cy-arsm]

@0xc0170 i have updated the summary comments with reason for the failure.

[mergify]

This PR cannot be merged due to conflicts. Please rebase to resolve them.

[0xc0170]

Once rebased ,will restart CI