Reverting #12312 as it breaking current WiFI connect()->Disconnect() sequence #12580
+0
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connect()->Disconnect() sequence This reverts commit 18285e1
|
@0xc0170 @morser499 Have accidentally closed the pull request #12513 while resolving the merge conflicts and not able to re-open it. |
|
@cy-arsm, thank you for your changes. |
|
CI started |
0xc0170
approved these changes
Mar 5, 2020
morser499
approved these changes
Mar 5, 2020
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
|
Client restarted |
|
CI completed. @ARMmbed/mbed-os-ipcore Please review |
|
@tymoteuszblochmobica / @mtomczykmobica Please review this |
|
Looks OK for me. |
adbridge
added
ready for merge
release-version: 6.0.0-alpha-3
and removed
mergify skip
needs: review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 18285e1.
Summary of changes
Issue:
In disconnect sequence, whd_emac_wifi_link_state_changed(FALSE) is called which is an asynchronous operation and execution is handled in tcp_ip thread(). As part of this api, it access the interface structure.
remove_ethernet_interface will remove the interface from the netif list, this is a synchronous execution and called after whd_emac_wifi_link_state_changed().
Hence there is synchronization issue, where whd_emac_wifi_link_state_changed() is trying to access the interface structure which is already freed by remove_ehternet_interface(). Hence crash is seen.
Hence reverting the remove interface in SoftAP->stop() and STA->disconnect() as it breaking the current WiFi connect()->disconnect() sequence.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers