TLSSocket: Remove deprecated connect #12543
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kivaisan
changed the title
|
@kivaisan, thank you for your changes. |
jarvte
approved these changes
Mar 2, 2020
kjbracey
previously approved these changes
Mar 2, 2020
There was a problem hiding this comment.
This currently conflicts with #12487, which gives this line an override. That would have caused a compilation error diagnosing the mistake, but I didn't see it because it's inside an #ifdef.
I'll rebase that PR on top of this one.
|
CI started |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
String based connect has been removed but was still defined in TLSSocket header for offloaded variant. This is a regression fix for 458957d
|
Kevin's PR got merged first, so I rebased this with latest master. |
0xc0170
approved these changes
Mar 3, 2020
|
CI restarted |
Test run: SUCCESSSummary: 7 of 7 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
String based connect has been removed but was still defined in TLSSocket header for offloaded variant.
This is a regression fix for 458957d
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan