Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPGA UART test cases addition with 7 and 9 bits data length #12615

Merged
merged 6 commits into from
Jun 10, 2020
Merged

FPGA UART test cases addition with 7 and 9 bits data length #12615

merged 6 commits into from
Jun 10, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Implementation done to verify #12611

New command to execute fpga tests:

mbed test -n tests*fpga* --app-config tests/configs/fpga.json

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team March 11, 2020 12:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test please review.

0xc0170
0xc0170 previously approved these changes Mar 19, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2020

CI started

Note: dynamic test will most likely fail, will be fixed today

@mergify mergify bot added needs: CI and removed needs: review labels Mar 19, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 19, 2020

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 19, 2020
@jeromecoutant
Copy link
Collaborator Author 

* jenkins-ci/mbed-os-ci_greentea-test

I suppose you don't execute tests with the new config file...

mbed test -n testsfpga --app-config tests/configs/fpga.json

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

That could be it

I suppose you don't execute tests with the new config file...

@ARMmbed/mbed-os-test Is this the case?

@adbridge
Copy link
Contributor

That could be it

I suppose you don't execute tests with the new config file...

@ARMmbed/mbed-os-test Is this the case?

@jamesbeyond Can you answer this ?

@mergify mergify bot added needs: CI and removed needs: work labels Mar 30, 2020
@jamesbeyond
Copy link
Contributor

jamesbeyond commented Mar 30, 2020 •
edited
Loading

Hi, @jeromecoutant. Thanks for the changes!
actually we having a very similar JSON FPGA file, in our test scripts repo. but not in the mbed-os repo.
Thanks for put it here, I think it would be useful to all the users as well.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 30, 2020

#12615 (comment)

@jeromecoutant My understanding is that tests failed due to this change, we need to enable this config in CI, correct?

@jeromecoutant
Copy link
Collaborator Author

Yes,

because test is now defining more test cases than each target can support...

Target capability is is the new tests/configs/fpga.json

Then, 2 things to do:

  • use in CI this new config file
  • maybe update K64F with its capability

@jamesbeyond
Copy link
Contributor

Then, 2 things to do:

  • use in CI this new config file
  • maybe update K64F with its capability

In this case, we will need to raise PR to fix our CI script. in order to make the test not break, I'd suggest

  1. in this PR, @jeromecoutant could you just keep the fpga.json, and do not change targets.json
  2. once this PR is merged, I'll raise a PR to our CI scripts repo. to use the new fpga.json
  3. once 2 is merged, I'll create a new PR, to remove those lines in the targets.json

@jeromecoutant jeromecoutant mentioned this pull request Mar 30, 2020
Merged
@mergify mergify bot dismissed 0xc0170’s stale review March 30, 2020 16:08

Pull request has been modified.

@jeromecoutant
Copy link
Collaborator Author

Rebase and json file removed from this PR

Now waiting for #12719 and the next one

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

CI started meanwhile

Now waiting for #12719 and the next one

Dependency here?

@mbed-ci
Copy link

mbed-ci commented Apr 1, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Apr 1, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented May 8, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 9
Build artifacts

@mergify mergify bot added the needs: work label May 12, 2020
@mergify
Copy link

mergify bot commented May 12, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot removed the needs: CI label May 12, 2020
@jeromecoutant
Copy link
Collaborator Author

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Done

fkjagodzinski
fkjagodzinski approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeromecoutant
Copy link
Collaborator Author

ping

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2020

@jeromecoutant Thanks for the reminder, this should have progress asap, sorry for the delay

CI started

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch and removed needs: work labels Jun 10, 2020
@mbed-ci
Copy link

mbed-ci commented Jun 10, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 10
Build artifacts

@0xc0170 0xc0170 merged commit 698fc09 into ARMmbed:master Jun 10, 2020
@mergify mergify bot removed the ready for merge label Jun 10, 2020
@jeromecoutant jeromecoutant deleted the PR_FPGA_UART branch June 10, 2020 12:59
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @adbridge @jamesbeyond @fkjagodzinski