Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nanostack: Add config for Wi-SUN device type #12648

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Nanostack: Add config for Wi-SUN device type #12648

merged 1 commit into from
Mar 20, 2020

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Mar 18, 2020

Summary of changes

Add new configuration option for Wi-SUN device type. Device type can configured to be either router or border router.

Impact of changes

Allow Wi-SUN application device type of Wi-SUN device.

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify bot added the needs: work label Mar 18, 2020
@ciarmcom ciarmcom requested review from a team March 18, 2020 18:00
@ciarmcom
Copy link
Member

@artokin, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

Nanostack: Add config for Wi-SUN device type
1b17179 
Add configuration option for Wi-SUN device types.
@artokin artokin force-pushed the nanostack_wisun_device_type_config branch from efc907f to 1b17179 Compare March 19, 2020 06:45
mikter
mikter reviewed Mar 19, 2020
View reviewed changes
features/nanostack/mbed-mesh-api/mbed_lib.json
@@ -159,6 +159,10 @@
"value_max": 255,
"value": 255
},
"wisun-device-type": {
"help": "Supported device operating modes: MESH_DEVICE_TYPE_WISUN_ROUTER, MESH_DEVICE_TYPE_WISUN_BORDER_ROUTER",
"value": "MESH_DEVICE_TYPE_WISUN_ROUTER"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would just MESH_DEVICE_TYPE_ROUTER be enough and sort of generic

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those could be used also in 6LoWPAN

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using already two conventions for device type:

  • 6Lowpan is already having 6lowpan-nd-device-type with alues NET_6LOWPAN_ROUTER and NET_6LOWPAN_HOST are used.

  • thread is having thread-device-type with values MESH_DEVICE_TYPE_THREAD_ROUTER, MESH_DEVICE_TYPE_THREAD_SLEEPY_END_DEVICE, MESH_DEVICE_TYPE_THREAD_MINIMAL_END_DEVICE and MESH_DEVICE_TYPE_THREAD_ROUTER.

We just need to select if we follow 6LoWPAN or Thread convention here.

@artokin artokin mentioned this pull request Mar 19, 2020
Merged
@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 20, 2020

Test run: SUCCESS

Summary: 8 of 8 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 1b83d31 into ARMmbed:master Mar 20, 2020
@mergify mergify bot removed the ready for merge label Mar 20, 2020
@artokin artokin deleted the nanostack_wisun_device_type_config branch March 23, 2020 06:30
@mikaleppanen mikaleppanen mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

@mikter mikter mikter approved these changes

@mikaleppanen mikaleppanen Awaiting requested review from mikaleppanen

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@artokin @ciarmcom @adbridge @mbed-ci @mikter