Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-wisun] Nanostack: Add config for Wi-SUN device type #12656

Merged

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Mar 19, 2020

Summary of changes

Add configuration option for Wi-SUN device types. This PR cherry-pick changes from #12648 to the feature-wisun branch.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-mesh @teetak01


Add configuration option for Wi-SUN device types.
@ciarmcom
Copy link
Member

@artokin, thank you for your changes.
@teetak01 @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Mar 19, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 19, 2020

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 19, 2020
@artokin artokin requested review from mikaleppanen, mikter, juhhei01, JarkkoPaso and a team and removed request for juhhei01, JarkkoPaso, mikter and mikaleppanen March 20, 2020 12:26
@artokin
Copy link
Contributor Author

artokin commented Mar 23, 2020

There are 60 failures, 379 skipped and 5,266 tests in the greentea test results. The failures seems to happen in sleep and USB features.

In the previous PR to feature-wisun branch (#12562) there were 12 failures, 6 skipped and 4,345 tests. The failing tests were all sleep related.

@0xc0170 , there has been a lot of changes in the greentea test set. Should we include some fixes from the Mbed OS master to this feature-wisun branch to get more test passing? Or are the failing tests acceptable for the feature branch.

@artokin artokin merged commit aa375c4 into ARMmbed:feature-wisun Mar 23, 2020
@artokin artokin deleted the fea_wisun_nanostack_device_type_config branch March 23, 2020 09:59
@artokin
Copy link
Contributor Author

artokin commented Mar 23, 2020

Agreed with @0xc0170 , test failures are acceptable for this feature-branch.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

USB has been also on master the last week once, I'll review today other Prs if this is master issue.

sleep should be fixed on the branch to make test pass and make Prs green to process PR faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants