Skip to content

Fixed compile error on targets where DEVICE_SPI or DEVICE_INTERRUPTIN are defined but not both #13471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

talorion
Copy link
Contributor

Summary of changes

Fixed a missmatch in the guards in NanostackRfPhyAtmel.h and NanostackRfPhyAT86RF215.cpp
the problem is better described in #13299
basically when either DEVICE_SPI or DEVICE_INTERRUPTIN are defined but not both we running Into the problem that the guards in NanostackRfPhyAtmel.h do not match the ones in NanostackRfPhyAT86RF215.cpp
I added a guard in rfbits.h which checks if DEVICE_SPI is defined since the file clearly requires SPI.

Impact of changes

on some custom targets where DEVICE_SPI or DEVICE_INTERRUPTIN are defined but not both the build fails

Migration actions required

Documentation

None

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@mergify mergify bot added the needs: work label Aug 20, 2020
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 20, 2020
@ciarmcom ciarmcom requested a review from a team August 20, 2020 18:00
@ciarmcom
Copy link
Member

@talorion, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clean the commit history - 2 merge commits could be eliminated if rebased.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2020

Thanks for fixing the issue. We will review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants