-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix for targets where DEVICE_SPI or DEVICE_INTERRUPTIN are defined but not both #13472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
copy of #13471 |
@talorion, thank you for your changes. |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@artokin can you review - the drivers changes to rf, should be also upstream? |
LGTM, @JarkkoPaso , would you please check also? |
Thank you @artokin @JarkkoPaso |
@0xc0170 , changes will be backported to mbed-os-5.15 via https://github.com/ARMmbed/atmel-rf-driver repository |
Summary of changes
Fixed a missmatch in the guards in NanostackRfPhyAtmel.h and NanostackRfPhyAT86RF215.cpp
the problem is better described in #13299
basically when either DEVICE_SPI or DEVICE_INTERRUPTIN are defined but not both we running Into the problem that the guards in NanostackRfPhyAtmel.h do not match the ones in NanostackRfPhyAT86RF215.cpp
I added a guard in rfbits.h which checks if DEVICE_SPI is defined since the file clearly requires SPI.
Impact of changes
on some custom targets where DEVICE_SPI or DEVICE_INTERRUPTIN are defined but not both the build fails
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers