proposed change of gpio_api #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently targets use different definitions for the PullDefault. Maybe it could make sense to unify the default for all targets to have a consistent behaviour. But this may have impact on user code as behavior would change for some targets. |
|
I am afraid of the impact of code size and runtime performance for application, since it will generate more static initialization code when application has a lot of global instances. |
|
Hi Watarai-san If we want to optimize this we should move the constructors for the Michael |
|
created new pull request #198 to address concern from watarai-san |
pan-
added a commit
to pan-/mbed
that referenced
this pull request
May 29, 2020
Move deprecated examples
ccli8
pushed a commit
to ccli8/mbed-os
that referenced
this pull request
Aug 13, 2024
* Fix STM32 I2C v2 async transfer not doing a repeated start * Clarify docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the gpio_init function is configuring a gpio either to pull low or to output low. This can be a problem if you need to respect timing of a pin or only set the pin low only when it should be. An example could be initializing multiple chip selects on an SPI bus. There is no way to init a pin as "input pull none" or "output high" or "input pull high". Therefore I am proposing a change to the gpio api.
The function gpio_init should only create the gpio object and not apply any changes to the hardware.
Unfortunately this change affects all targets. And I am not able to test them.