proposed change of gpio_api (new update pull request) #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reating a set of common initialization functions
| * limitations under the License. | ||
| */ | ||
| #include "gpio_api.h" | ||
|
|
There was a problem hiding this comment.
Can you replace this preprocessor usage by a function call with the static inline specifiers? Will be easier to debug.
|
the two issues solved with the additional commits from Yesterday. Is there any chance that you accept this pull reuqest? |
|
This looks OK, so I'm going to accept it, but it is a high risk change, as it touches all targets, so it will have to be thoroughly tested. Also, the change set makes a separate change to serial_api.c on LPC1768 that I will address later. |
bogdanm
added a commit
that referenced
this pull request
Mar 10, 2014
proposed change of gpio_api (new update pull request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated pull request (was #197) to address concern from watarai-san.