Skip to content

tools-exporters! - Move to Toolchain-polymorphic makefiles #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 15, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Aug 29, 2016

This creates three new exporters:

  • make_gcc_arm (new name for old exporter)
  • make_armc5
  • make_iar

There is also a bunch of consolodation work that significantly reduces the difference between the python build system and the makefiles. Further, I also significantly reduced the number of extrainious templates by allowing templates resolution to fall back from the target name, to the extra-labels, and finally to the toolchain-specific makefile.

This PR must be merged after #2245 It was merged!

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Aug 29, 2016

@sg-
Copy link
Contributor

sg- commented Sep 9, 2016

@theotherjimmy how about a rebase?

@sg-
Copy link
Contributor

sg- commented Sep 9, 2016

🎉

@theotherjimmy
Copy link
Contributor Author

re-re-based.

@sg-
Copy link
Contributor

sg- commented Sep 12, 2016

/morph test

@sg-
Copy link
Contributor

sg- commented Sep 12, 2016

/morph export-build

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 841

All builds and test passed!

@sg-
Copy link
Contributor

sg- commented Sep 13, 2016

Just a handful of IAR failures left, not a regression but probably missing definitions or simple fix-ups for a future patch

15:53:00 Failed: 
15:53:00   * DISCO_F469NI::iar  MBED_BLINKY
15:53:00   * EFM32PG_STK3401::iar   MBED_BLINKY
15:53:00   * NUCLEO_F410RB::iar MBED_BLINKY
15:53:00   * NUCLEO_F767ZI::iar MBED_BLINKY
15:53:00   * NUCLEO_L073RZ::iar MBED_BLINKY
15:53:00   * NUCLEO_L432KC::iar MBED_BLINKY

@ohagendorf
Copy link
Contributor

After submitting your PR three new gcc_arm templates appeared:
gcc_arm_disco_f769ni.tmpl
gcc_arm_mtm_mtconnect04S.tmpl
gcc_arm_nucleo_f303ke.tmpl

May you have a look at these too, please.

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Sep 14, 2016

  • gcc_arm_disco_f769ni.tmpl: a direct copy of the base template with no modification. It will just fall back to the base template.
  • gcc_arm_mtm_mtconnect04S.tmpl: A srec_cat user and the scan resources will pick up a .hex file. This will also fall back to the base template, and have the hex file merging as part of the all target
  • gcc_arm_nucleo_f303ke.tmpl: Same as the disco_f769ni

These will be taken care of without the need for extra templates. Thanks for the heads up @ohagendorf

@ohagendorf
Copy link
Contributor

But they can be deleted to clean up the export folder ...

@theotherjimmy
Copy link
Contributor Author

OH did I not delete them? I'll get right on that.

@theotherjimmy
Copy link
Contributor Author

@ohagendorf, I did a rebase to remove the templates you mentioned in the appropriate commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants