[Exporters] [Makefile] Single quotes for escaping commands

[sarahmarshy]

Description

Commands must be in quotes on Windows, in case the path contains spaces. Previously, they were escaped with ", but it seems like ' is more agreeable to Windows.

Status

READY

Migrations

NO

Related PRs

List related PRs against other branches:
#2577

Todos

• Tests
• Documentation

Steps to test or reproduce

Only reproducible on Windows
Run this from master:
mbed export -m whatever -i make_iar
Try to execute the makefile.
Repeat with this PR.

@sg- @theotherjimmy @screamerbg

[theotherjimmy]

👍

[sg-]

Wow - that was it?

[sg-]

@sarahmarshy do we have these as part of export-build tests yet?

[sarahmarshy]

No, I can add to #2754 though. I will look a little strange, as the build calls are still in progen, while makefile is entirely in mbed. I can override the progen build method in the Makefile, but obviously the function name "ProgenBuild" will be a little misleading. The alternative is making a separate function call in the build tests for make.

[sarahmarshy]

@sg- remembered this fun thing when I was implementing this: the makefile must be executed in the directory with source. I'll have to copy all relevant source into the .build/export folder where the tests are exported (normally just the project file). Little less trivial, but it shouldn't be too bad.

[sg-]

I don't understand. Why isn't the test mbed import <program url> ; mbed export <gcc_compiler> ; make ??

[sarahmarshy]

I can transition all the tests to import for mbed 5. But they don't work that way right now. They pick up source references from the TESTS dir and the root of mbed-os. Also, for mbed 2, I am just using the test class that exists now. There is no copying of files for export tests. The project files reference source from disparate parts of the source tree.