Add RTOS configuration for default stack size #2646
Conversation
|
This is a work around more than a solution. Gonna think more about this. |
|
@sg- do you not think that this is a reasonable thing that people might (albeit rarely) want to configure? |
|
@bogdanm @sg- @matthewelse I also find this very reasonable. I know that with BLE + TLS on nRF51 we actually liked to increase the stack size, but was not possible. And Multitech now had a bigger stack than needed in #2635... |
|
Concerns are that development for multi-threaded systems and single threaded systems are different and passing the stack size with an application doesn't solve any problems, it just masks them. For example: https://github.com/ARMmbed/mbed-os-example-tls/blob/master/tls-client/main.cpp#L270 If this is used once, dynamic allocation would be a better approach. If used a few times or many, this should be statically allocated or belong to the class/translation unit. I'd guess there are a lot of places where the amount of resource to perform a task is hidden in similar ways. I think there is a general 'rules of good practice' that should be drafted and then this wont be an issue. I'd expect until then and for a while these things creep up especially when the previous releases allow failure conditions to go uncaught. The plan of record at the moment is to make things as deterministic and reproducible as possible. |
This pull request adds default stack size as a configuration option for the RTOS library. Since this exactly replicates the previous functionality, this pull request does not result in any functional changes.
This is mainly helpful for single-threaded projects, where creating a new thread just to set the stack size is unnecessary.
From what I can tell this is relevant to #2631 and #2635, and is needed in jerryscript-project/jerryscript#1318 to support parsing non-trivial javascript files.
cc: @janjongboom