adding option to change stack size from compilation #3308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
changed the title
|
It looks like your intended title did not get picked up correctly by github. If I got the title wrong, please feel free to change it. |
|
Hi @netanelgonen, thanks for the interest in contributing to mbed-os! It looks like your commit message may have been messed a bit, would you be able to remove the user/email part of the commit message? These should already be recorded by git. You should be able to change the commit message with these commands: |
email :netgon01@arm.com adding option to change stack size from compilation. this will give easyer way to change the stack size without changing the code. add the option to set stack size from compilation adding check if WORDS_STACK_SIZE was not defined before setting it. so if defined from compilation it will not use the default that set hard coded it will make controlling the stack size easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Description
enable defining the WORDS_STACK_SIZE from compilation
this will create easier way to change the stack size without touching the code
Status
READY
email :netgon01@arm.com
adding option to change stack size from compilation.
this will give easier way to change the stack size without
changing the code.