[NUC472/M453] Support USB device #3365

ccli8 · 2016-12-05T07:53:11Z

Description

This PR includes NuMaker-PFM-NUC472/NuMaker-PFM-M453's support for USB device.

0xc0170 · 2016-12-05T16:51:06Z

bridadan · 2016-12-08T17:14:56Z

Thanks for the PR @ccli8! Currently the only USB testing that's done by CI is a build test done by Travis CI.

Could you please make similar edits for the appropriate platforms in this PR like I made here: https://github.com/ARMmbed/mbed-os/pull/3169/files#diff-41911d756af2c8c1e30cb1228ed5b7c3L98

That will enable USB build testing. Thanks!

1. Add targets into build_travis.py and tests.py. 2. Add target SPI pins into SPI SD test samples. 3. Rename target TOOLCHAIN_GCC_ARM/retarget.c to avoid name collision of compiled retarget.o with platform/retargets.cpp.

ccli8 · 2016-12-09T06:03:12Z

@bridadan Hi, I've made such edits. Please check it.

Besides, on NUMAKER_PFM_NUC472, I meet compile error with mbedtls. It is a known issue with #3006.

0xc0170 · 2016-12-09T13:39:28Z

features/unsupported/USBDevice/USBDevice/USBEndpoints_M453.h

@@ -0,0 +1,65 @@
+


please add license header here

@0xc0170 I've added it with fc16917.

0xc0170 · 2016-12-09T13:39:40Z

features/unsupported/USBDevice/USBDevice/USBEndpoints_NUC472.h

@@ -0,0 +1,75 @@
+


same here - license

Same as above.

bridadan · 2016-12-09T15:29:07Z

@ccli8 Thanks so much for adding the build tests! Unfortunately we can't merge this if Travis CI is failing as it will cause all others to start failing as well.

@0xc0170 do we have a way forward to address #3006?

Use MBED_CONF_RTOS_PRESENT to filter out mbedtls alternative for mbed OS 2.

ccli8 · 2016-12-15T03:51:39Z

@bridadan Following #3096 I use MBED_CONF_RTOS_PRESENT to filter out mbedtls alternative to pass Travis CI check.

bridadan · 2016-12-15T17:15:52Z

@ccli8 It looks like a FAT filesystem test is failing to compile in Travis CI:

Executing: python tools/make.py -m NUMAKER_PFM_NUC472 -t GCC_ARM -c --silent --fat -n MBED_A12,MBED_19,PERF_1,PERF_2,PERF_3 
Image: /home/travis/build/ARMmbed/mbed-os/BUILD/test/NUMAKER_PFM_NUC472/GCC_ARM/MBED_A12/sd.bin
[ERROR] /home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp: In function 'void test_write(FILE*, const char*)':
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:44:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (n != strlen(str)) {
           ^
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp: In function 'int main()':
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:87:21: error: 'p11' was not declared in this scope
     SDFileSystem sd(p11, p12, p13, p14, "sd");
                     ^
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:87:26: error: 'p12' was not declared in this scope
     SDFileSystem sd(p11, p12, p13, p14, "sd");
                          ^
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:87:31: error: 'p13' was not declared in this scope
     SDFileSystem sd(p11, p12, p13, p14, "sd");
                               ^
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:87:36: error: 'p14' was not declared in this scope
     SDFileSystem sd(p11, p12, p13, p14, "sd");
                                    ^
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:25:23: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
 #define TEST_STRING   "Hello World!"
                       ^
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:92:17: note: in expansion of macro 'TEST_STRING'
     char *str = TEST_STRING;
                 ^
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:93:11: warning: unused variable 'buffer' [-Wunused-variable]
     char *buffer = (char *)malloc(sizeof(unsigned char) * strlen(TEST_STRING));
           ^
/home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:94:9: warning: unused variable 'str_len' [-Wunused-variable]
     int str_len = strlen(TEST_STRING);
         ^
In file included from /home/travis/build/ARMmbed/mbed-os/BUILD/mbed/TARGET_NUMAKER_PFM_NUC472/TARGET_NUVOTON/TARGET_NUC472/device/NUC472_442.h:32577:0,
                 from /home/travis/build/ARMmbed/mbed-os/BUILD/mbed/TARGET_NUMAKER_PFM_NUC472/TARGET_NUVOTON/TARGET_NUC472/device/cmsis.h:20,
                 from /home/travis/build/ARMmbed/mbed-os/BUILD/mbed/TARGET_NUMAKER_PFM_NUC472/TARGET_NUVOTON/TARGET_NUC472/TARGET_NUMAKER_PFM_NUC472/objects.h:20,
                 from /home/travis/build/ARMmbed/mbed-os/BUILD/mbed/TARGET_NUMAKER_PFM_NUC472/TARGET_NUVOTON/TARGET_NUC472/TARGET_NUMAKER_PFM_NUC472/device.h:22,
                 from /home/travis/build/ARMmbed/mbed-os/BUILD/mbed/platform/platform.h:27,
                 from /home/travis/build/ARMmbed/mbed-os/BUILD/mbed/mbed.h:51,
                 from /home/travis/build/ARMmbed/mbed-os/features/unsupported/tests/mbed/dir_sd/main.cpp:1:
/home/travis/build/ARMmbed/mbed-os/BUILD/mbed/TARGET_NUMAKER_PFM_NUC472/TARGET_NUVOTON/TARGET_NUC472/device/StdDriver/nuc472_cap.h: At global scope:
/home/travis/build/ARMmbed/mbed-os/BUILD/mbed/TARGET_NUMAKER_PFM_NUC472/TARGET_NUVOTON/TARGET_NUC472/device/StdDriver/nuc472_cap.h:86:17: warning: 'u32EscapeFrame' defined but not used [-Wunused-variable]
 static uint32_t u32EscapeFrame = 0;

Looks like you just need to add valid pins to the test.

…s CI

ccli8 · 2016-12-16T01:46:38Z

@bridadan I added SPI SD pins to failed samples. Please continue the check.

bridadan · 2016-12-27T16:52:37Z

/morph test

mbed-bot · 2016-12-27T18:01:22Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1329

All builds and test passed!

0xc0170 · 2016-12-30T11:25:57Z

features/unsupported/USBDevice/USBDevice/USBEndpoints_M453.h

+#define NU_MAX_EPX_BUFSIZE      4096
+#define NU_EP2EPL(ep)           ((ep) >> 1)
+#define NU_EP2EPH(ep)           (((ep) >> 1) + 1)
+#define NU_EPL2EPH(ep)					((ep) + 1)


Can you please fix the formatting in this file? the line 19 (there are more). Using tabs?

Fix with another PR #3514.

0xc0170 · 2016-12-30T11:26:26Z

features/unsupported/USBDevice/USBDevice/USBEndpoints_NUC472.h

+#define NU_EP2EPL(ep)           ((ep) >> 1)
+#define NU_EP2EPH(ep)           (((ep) >> 1) - 1)
+#define NU_EPX2EP(ep)          ((ep == CEP) ? EP0OUT : ((ep) - EPA + EP1OUT))
+#define NU_EPL2EPH(ep)					((ep) - 1)


same here (alignment)

Fix with another PR #3514.

0xc0170

Future reference: code style

LGTM as it is, you can send a patch to fix.

Ports for Upcoming Targets 3459: Target: Add new target UBLOX_EVK_NINA_B1 ARMmbed/mbed-os#3459 Fixes and Changes 3430: Fix ci shield eeprom test ARMmbed/mbed-os#3430 3381: STM32F1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3381 3389: STM32F2 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3389 3390: STM32F3 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3390 3410: STM32L4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3410 3422: Enable CAN on DISCO_F303VC ARMmbed/mbed-os#3422 3442: Dev stm i2c f1 ARMmbed/mbed-os#3442 3460: KSDK I2C: Update the return value to match the API documentation change ARMmbed/mbed-os#3460 3472: [RZ/A1H]Fix TTB setting of RO_DATA area ARMmbed/mbed-os#3472 3451: Rename KSDK2 to MCUXpresso. This is the new name of this package ARMmbed/mbed-os#3451 3391: STM32F4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3391 3454: STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files ARMmbed/mbed-os#3454 3489: NUCLEO_F103RB - Correct CAN and PWM alternate-functions ARMmbed/mbed-os#3489 3405: Repair the transmit mailbox (0,1,2) empty interrupt flag not clear BUG ARMmbed/mbed-os#3405 3502: MCUXpresso I2C: Handle 0 byte write ARMmbed/mbed-os#3502 3365: [NUC472/M453] Support USB device ARMmbed/mbed-os#3365

[NUC472/M453] Support USB device

7f4881f

0xc0170 added the needs: review label Dec 5, 2016

[NUC472/M453] Integrate with Travis CI

8c0948d

1. Add targets into build_travis.py and tests.py. 2. Add target SPI pins into SPI SD test samples. 3. Rename target TOOLCHAIN_GCC_ARM/retarget.c to avoid name collision of compiled retarget.o with platform/retargets.cpp.

0xc0170 requested changes Dec 9, 2016

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Dec 9, 2016

ccli8 added 2 commits December 12, 2016 09:19

[NUC472/M453] Add license header for USBEndpoints_NUC472/M453.h

fc16917

[NUC472] Fix compile error with Travis CI

fff8357

Use MBED_CONF_RTOS_PRESENT to filter out mbedtls alternative for mbed OS 2.

[NUC472/M453] Add target SPI pins into SPI SD test samples with Travi…

5fe2274

…s CI

0xc0170 approved these changes Dec 21, 2016

View reviewed changes

0xc0170 added needs: review and removed needs: work labels Dec 21, 2016

bridadan added the needs: CI label Dec 27, 2016

bridadan removed the needs: CI label Dec 27, 2016

0xc0170 approved these changes Dec 28, 2016

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Dec 28, 2016

0xc0170 requested changes Dec 30, 2016

View reviewed changes

0xc0170 approved these changes Dec 30, 2016

View reviewed changes

0xc0170 added release-version: 5.3.2 and removed ready for merge labels Dec 30, 2016

0xc0170 merged commit e7361eb into ARMmbed:master Dec 30, 2016

ccli8 mentioned this pull request Jan 3, 2017

[NUC472/M453] Remove Tab in USB HAL #3514

Merged

bcostm mentioned this pull request Jan 3, 2017

NUCLEO_F401RE - SPI, PWM and InterruptIn failues (CI test shield) #3501

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NUC472/M453] Support USB device #3365

[NUC472/M453] Support USB device #3365

ccli8 commented Dec 5, 2016

0xc0170 commented Dec 5, 2016

bridadan commented Dec 8, 2016

ccli8 commented Dec 9, 2016

0xc0170 Dec 9, 2016

ccli8 Dec 12, 2016

0xc0170 Dec 9, 2016

ccli8 Dec 12, 2016

bridadan commented Dec 9, 2016

ccli8 commented Dec 15, 2016

bridadan commented Dec 15, 2016

ccli8 commented Dec 16, 2016

bridadan commented Dec 27, 2016

mbed-bot commented Dec 27, 2016

0xc0170 Dec 30, 2016

ccli8 Jan 3, 2017

0xc0170 Dec 30, 2016

ccli8 Jan 3, 2017

0xc0170 left a comment

[NUC472/M453] Support USB device #3365

[NUC472/M453] Support USB device #3365

Conversation

ccli8 commented Dec 5, 2016

Description

0xc0170 commented Dec 5, 2016

bridadan commented Dec 8, 2016

ccli8 commented Dec 9, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bridadan commented Dec 9, 2016

ccli8 commented Dec 15, 2016

bridadan commented Dec 15, 2016

ccli8 commented Dec 16, 2016

bridadan commented Dec 27, 2016

mbed-bot commented Dec 27, 2016

Output

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 left a comment

Choose a reason for hiding this comment