STM32F2 : map ST HAL assert into MBED assert #3389
Conversation
| @@ -304,7 +304,7 @@ void gpio_irq_set(gpio_irq_t *obj, gpio_irq_event event, uint32_t enable) | |||
| mode = STM_MODE_IT_FALLING; | |||
| obj->event = EDGE_FALL; | |||
| } else { // NONE or RISE | |||
| mode = STM_MODE_IT_EVT_RESET; | |||
| mode = STM_MODE_INPUT; | |||
There was a problem hiding this comment.
Are these GPIO changes related to the assert changes? Or did these come in by mistake?
There was a problem hiding this comment.
No mistake :-)
This mode is sent to ST HAL, but STM_MODE_IT_EVT_RESET is not part of GPIO mode values...
I then set the default value.
(issue was seen with MBED_A7 test)
There was a problem hiding this comment.
Please amend the second commit to be more clear as you did to other patches, thanks
- GPIO: mode was not allowed by ST HAL API
jeromecoutant
force-pushed
the
PR_ST_F2_ASSERT
branch
from
5da9c54 to
008a123
Compare
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
Test failure is ok, timing failure due to test machine load 👍 |
No red X on the CI. This will block the patch from merging. /morph test |
|
retest uvisor |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
Looks like the Public Test Result VM went down for some reason with no warning. It's back up now, restarting the job. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Ports for Upcoming Targets 3459: Target: Add new target UBLOX_EVK_NINA_B1 ARMmbed/mbed-os#3459 Fixes and Changes 3430: Fix ci shield eeprom test ARMmbed/mbed-os#3430 3381: STM32F1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3381 3389: STM32F2 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3389 3390: STM32F3 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3390 3410: STM32L4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3410 3422: Enable CAN on DISCO_F303VC ARMmbed/mbed-os#3422 3442: Dev stm i2c f1 ARMmbed/mbed-os#3442 3460: KSDK I2C: Update the return value to match the API documentation change ARMmbed/mbed-os#3460 3472: [RZ/A1H]Fix TTB setting of RO_DATA area ARMmbed/mbed-os#3472 3451: Rename KSDK2 to MCUXpresso. This is the new name of this package ARMmbed/mbed-os#3451 3391: STM32F4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3391 3454: STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files ARMmbed/mbed-os#3454 3489: NUCLEO_F103RB - Correct CAN and PWM alternate-functions ARMmbed/mbed-os#3489 3405: Repair the transmit mailbox (0,1,2) empty interrupt flag not clear BUG ARMmbed/mbed-os#3405 3502: MCUXpresso I2C: Handle 0 byte write ARMmbed/mbed-os#3502 3365: [NUC472/M453] Support USB device ARMmbed/mbed-os#3365
Description
ST HAL assert is mapped onto MBED HAL assert, and can now be enabled easily.
Note for all STM32 targets:
Test
OS2 and OS5 tests done.
Few updates have been needed to match ST HAL API.
Status
READY