Remove unnecessary absolute paths from IAR and ARM compilers #3414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the absolute path causes a file error if the compiler paths are configured incorrectly. It uses a relative path instead now (the files appears to be in the default search path).
bridadan
changed the title
|
/morph export-build |
|
/morph test |
|
@mbed-bot: TEST HOST_OSES=ALL |
theotherjimmy
approved these changes
Dec 9, 2016
|
|
||
| c_flags_cmd.extend([ | ||
| "--thumb", "--dlib_config", "DLib_Config_Full.h" | ||
| ]) |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 50 Exporter Build failed! |
|
Failure should be fixed by #3416 |
|
[Build 1159] |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
3 tasks
|
LGTM |
|
#3416 is now merged, rerunning exporter tests now. /morph export-build |
|
retest uvisor |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 61 All exports and builds passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both the ARM and IAR compilers use absolute paths to explicitly include their standard libraries. It seems that for both of these compilers, these paths are already in their default search paths, so using an absolute path is not necessary. This fixes an issue when exporting to make and the paths are incorrectly configured. This should now work out-of-the box.
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Todos
Notes
Requesting @theotherjimmy and @screamerbg to review this since it modifies the toolchains