Skip to content

Renames i2c_api.c for STM32F1 targets to fix IAR exporter #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2016
Merged

Renames i2c_api.c for STM32F1 targets to fix IAR exporter #3416

merged 1 commit into from
Dec 13, 2016

Conversation

bridadan
Copy link
Contributor

@bridadan bridadan commented Dec 9, 2016 •
edited
Loading

Description

The IAR build system does not allow two files to have the same name. This renames the i2c_api.c file for the STM32F1 family to i2c_api_stm32f1.c to avoid this issue. The common i2c_api.c file shared among all ST targets is not actually used for STM32F1 targets as it protected with an #ifdef guard.

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Todos

  • mbed OS 5 tests
  • mbed OS 2 test (should inclued uARM too)
  • exporter tests

Notes

Requesting a review from @LMESTM as they submitted the PR #3324 which made the i2c_api.c among all ST targets except the STM32F1 family.

@bridadan
Renames i2c_api.c for STM32F1 targets to fix IAR exporter.
6085905 
The IAR build system does not allow two files to have the same name.
This renames the i2c_api.c file for the STM32F1 family to
i2c_api_stm32f1.c to avoid this issue. The common i2c_api.c file shared
among all ST targets is not actually used for STM32F1 targets as it
protected with an #ifdef guard.
@bridadan
Copy link
Contributor Author

bridadan commented Dec 9, 2016

/morph export-build

@bridadan
Copy link
Contributor Author

bridadan commented Dec 9, 2016

/morph test

@bridadan
Copy link
Contributor Author

bridadan commented Dec 9, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@bridadan bridadan mentioned this pull request Dec 9, 2016
Merged
This was referenced Dec 9, 2016
Merged
Merged
@mbed-bot
Copy link

mbed-bot commented Dec 9, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 52

All exports and builds passed!

@bridadan bridadan requested review from theotherjimmy and removed request for theotherjimmy December 9, 2016 21:53
@mbed-bot
Copy link

mbed-bot commented Dec 9, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1248

All builds and test passed!

@bridadan
Copy link
Contributor Author

bridadan commented Dec 9, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 1160]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@LMESTM
Copy link
Contributor

LMESTM commented Dec 12, 2016

@bridadan Thanks for this !
(BTW, the file is about to disappear ...)

@sg-
Copy link
Contributor

sg- commented Dec 12, 2016

In a case like the mbed common files should be renamed.

@LMESTM
Copy link
Contributor

LMESTM commented Dec 12, 2016

@sg- the F1 i2c files is about to disappear in a coming PR (already ready here ...) so we'll be left with only 1 i2c_api.c file, common to all STM targets.

@adbridge
Copy link
Contributor

@LMESTM Do you have an ETA for when you are landing the new PR ?
@bridadan Any issue with holding back #3414 until this new PR lands? This PR here could then be ignored?

@LMESTM
Copy link
Contributor

LMESTM commented Dec 12, 2016

@adbridge up to you and @bridadan : I can send the PR incoming days this week for sure.
I just posted other I2C related PRs, and I'd like to get one of them as well before moving F1 to common code: #3429

@bridadan
Copy link
Contributor Author

@adbridge @sg- Since @LMESTM will be removing this file in the near future, it seems like renaming this one makes the most sense. It shouldn't be a breaking change.

@bridadan
Copy link
Contributor Author

@adbridge It should be ok to merge #3414 without this one, though the CI will remain failing as this PR patches the one failing target (aka can't make CI green on #3414 without this one).

@bridadan
Copy link
Contributor Author

As far as I'm concerned, this PR is ready to go. However marking my own PR as ready to merge is a bit self-serving, so I'll leave that up to rest of the maintainers 😄

@LMESTM
Copy link
Contributor

LMESTM commented Dec 13, 2016

@bridadan @adbridge I agree that we can go ahead with this change which will be temporary until I remove the file - as this is available now, it's good to take it I think

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 13, 2016

Thank you guys.

LGTM

@0xc0170 0xc0170 merged commit aa6780d into ARMmbed:master Dec 13, 2016
@theotherjimmy theotherjimmy mentioned this pull request Dec 13, 2016
Merged
1 task
This was referenced Dec 13, 2016
Closed
Closed
@LMESTM LMESTM mentioned this pull request Dec 14, 2016
Merged
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Release 132 of the mbed library
12c3a2c 
Ports for Upcoming Targets

3241: Add support for FRDM-KW41 ARMmbed/mbed-os#3241
3291: Adding mbed enabled Maker board with NINA-B1 and EVA-M8Q ARMmbed/mbed-os#3291

Fixes and Changes

3062: TARGET_STM :USB device FS  ARMmbed/mbed-os#3062
3213: STM32: Refactor us_ticker.c + hal_tick.c files ARMmbed/mbed-os#3213
3288: Dev spi asynch l0l1 ARMmbed/mbed-os#3288
3289: Bug fix of initial value of interrupt edge in "gpio_irq_init" function. ARMmbed/mbed-os#3289
3302: STM32F4 AnalogIn - Clear VBATE and TSVREFE bits before configuring ADC channels ARMmbed/mbed-os#3302
3320: STM32 - Add ADC_VREF label ARMmbed/mbed-os#3320
3321: no HSE available by default for NUCLEO_L432KC ARMmbed/mbed-os#3321
3352: ublox eva nina - fix line endings ARMmbed/mbed-os#3352
3322: DISCO_L053C8 doesn't support LSE ARMmbed/mbed-os#3322
3345: STM32 - Remove TIM_IT_UPDATE flag in HAL_Suspend/ResumeTick functions ARMmbed/mbed-os#3345
3309: [NUC472/M453] Fix CI failed tests ARMmbed/mbed-os#3309
3157: [Silicon Labs] Adding support for EFR32MG1 wireless SoC ARMmbed/mbed-os#3157
3301: I2C - correct return values for write functions (docs) - part 1 ARMmbed/mbed-os#3301
3303: Fix #2956 #2939 #2957 #2959 #2960: Add HAL_DeInit function in gpio_irq destructor ARMmbed/mbed-os#3303
3304: STM32L476: no HSE is present in NUCLEO and DISCO boards ARMmbed/mbed-os#3304
3318: Register map changes for RevG ARMmbed/mbed-os#3318
3317: NUCLEO_F429ZI has integrated LSE ARMmbed/mbed-os#3317
3312: K64F: SPI Asynch API implementation ARMmbed/mbed-os#3312
3324: Dev i2c common code ARMmbed/mbed-os#3324
3369: Add CAN2 missing pins for connector CN12 ARMmbed/mbed-os#3369
3377: STM32 NUCLEO-L152RE Update system core clock to 32MHz ARMmbed/mbed-os#3377
3378: K66F: Enable LWIP feature ARMmbed/mbed-os#3378
3382: [MAX32620] Fixing serial readable function. ARMmbed/mbed-os#3382
3399: NUCLEO_F103RB - Add SERIAL_FC feature ARMmbed/mbed-os#3399
3409: STM32L1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3409
3416: Renames i2c_api.c for STM32F1 targets to fix IAR exporter ARMmbed/mbed-os#3416
3348: Fix frequency function of CAN driver. ARMmbed/mbed-os#3348
3366: NUCLEO_F412ZG - Add new platform ARMmbed/mbed-os#3366
3379: STM32F0 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3379
3393: ISR register never re-evaluated in HAL_DMA_PollForTransfer for STM32F4 ARMmbed/mbed-os#3393
3408: STM32F7 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3408
3411: STM32L0 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3411
3424: STM32F4 - FIX to add the update of hdma->State variable ARMmbed/mbed-os#3424
3427: Fix stm i2c slave ARMmbed/mbed-os#3427
3429: Fix stm i2c fix init ARMmbed/mbed-os#3429
3434: [NUC472/M453] Fix stuck in lp_ticker_init and other updates ARMmbed/mbed-os#3434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@LMESTM LMESTM LMESTM approved these changes

Assignees
No one assigned
Labels
release-version: 5.3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bridadan @mbed-bot @LMESTM @sg- @adbridge @0xc0170 @theotherjimmy