-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32: Move types definitions to a common file #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you add a comment in the code for this? I think this will be useful to have documented for people who may make edits to this in the future. |
e23d2a3
to
bfa34c3
Compare
@bridadan sure - I added a comment in the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update @LMESTM!
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
retest uvisor |
@bridadan |
Only one point of attention: STM_MODE_ANALOG_ADC_CONTROL is a specific mode that is only supported on L4. So STM_MODE_ANALOG_ADC_CONTROL was moved to index 13 (last entry) of gpio_mode table so that all the other modes are common and only the last one is specific.
bfa34c3
to
42f6622
Compare
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Ports for Upcoming Targets 3571: DISCO_F769NI introduction ARMmbed/mbed-os#3571 3605: Add DELTA_DFCM_NNN50 platform ARMmbed/mbed-os#3605 3640: [MAX32630FTHR] Adding new platform ARMmbed/mbed-os#3640 Fixes and Changes 3397: Add uVisor support for the DISCO_F429ZI ARMmbed/mbed-os#3397 3573: fix failing RTC initialization for MTS_DRAGONFLY_F411RE ARMmbed/mbed-os#3573 3575: Dev stm factorize gpio ARMmbed/mbed-os#3575 3584: STM32: make PeripheralPins.h a common file ARMmbed/mbed-os#3584 3583: STM32F7 Cube FW new release v1.5.1 ARMmbed/mbed-os#3583 3578: Target system - Inherit names from target parents ARMmbed/mbed-os#3578 3599: K22F: Enable TRNG ARMmbed/mbed-os#3599 3614: STM32: make PortNames.h a common file ARMmbed/mbed-os#3614 3617: EFM32GG: Fix GCC_ARM linker script ARMmbed/mbed-os#3617 3618: STM32: Move types definitions to a common file ARMmbed/mbed-os#3618 3631: F3 CUBE update V1.7.0 ARMmbed/mbed-os#3631 3635: STM32 I2C : Fix bug in i2c_byte_read function ARMmbed/mbed-os#3635 3651: Max32630 - fix LED4 ARMmbed/mbed-os#3651
This makes gpio types definitions in common (defined at 1 place instead of 54 ..)
Only one point of attention:
STM_MODE_ANALOG_ADC_CONTROL is a specific mode that is only supported on L4.
So STM_MODE_ANALOG_ADC_CONTROL was moved to index 13 (last entry)
of gpio_mode table so that all the other modes are common and only the last
one is specific.
Status
READY
TESTS
All STM targets compile fine.
Non regression done on L476 with ci tests shields and results are OK
report_ci-test-shield_L476RG_AFTER_TYPES.txt
report_ci-test-shield_L476RG_BEFORE_TYPES.txt