Skip to content

STM32: Move types definitions to a common file #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

LMESTM
Copy link
Contributor

@LMESTM LMESTM commented Jan 20, 2017

This makes gpio types definitions in common (defined at 1 place instead of 54 ..)

Only one point of attention:
STM_MODE_ANALOG_ADC_CONTROL is a specific mode that is only supported on L4.
So STM_MODE_ANALOG_ADC_CONTROL was moved to index 13 (last entry)
of gpio_mode table so that all the other modes are common and only the last
one is specific.

Status

READY

TESTS

All STM targets compile fine.
Non regression done on L476 with ci tests shields and results are OK

report_ci-test-shield_L476RG_AFTER_TYPES.txt
report_ci-test-shield_L476RG_BEFORE_TYPES.txt

@bridadan
Copy link
Contributor

bridadan commented Jan 20, 2017

Only one point of attention:
STM_MODE_ANALOG_ADC_CONTROL is a specific mode that is only supported on L4.
So STM_MODE_ANALOG_ADC_CONTROL was moved to index 13 (last entry)
of gpio_mode table so that all the other modes are common and only the last
one is specific.

Can you add a comment in the code for this? I think this will be useful to have documented for people who may make edits to this in the future.

@LMESTM
Copy link
Contributor Author

LMESTM commented Jan 20, 2017

@bridadan sure - I added a comment in the code.

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update @LMESTM!

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1437

All builds and test passed!

@bridadan
Copy link
Contributor

retest uvisor

@LMESTM
Copy link
Contributor Author

LMESTM commented Jan 24, 2017

@bridadan
Hey - I just found out a last minute missing change in this PR: a few extra lines to delete to the BLUEPILL TARGET file (not an ST internal one, so rarely compiled).
Now done :-)

Only one point of attention:
STM_MODE_ANALOG_ADC_CONTROL is a specific mode that is only supported on L4.
So STM_MODE_ANALOG_ADC_CONTROL was moved to index 13 (last entry)
of gpio_mode table so that all the other modes are common and only the last
one is specific.
@LMESTM LMESTM force-pushed the dev_stm32_PinNamesTypes branch from bfa34c3 to 42f6622 Compare January 24, 2017 09:59
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 24, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1446

All builds and test passed!

@0xc0170 0xc0170 merged commit bdcda38 into ARMmbed:master Jan 26, 2017
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Ports for Upcoming Targets

3571: DISCO_F769NI introduction ARMmbed/mbed-os#3571
3605: Add DELTA_DFCM_NNN50 platform ARMmbed/mbed-os#3605
3640: [MAX32630FTHR] Adding new platform ARMmbed/mbed-os#3640

Fixes and Changes

3397: Add uVisor support for the DISCO_F429ZI ARMmbed/mbed-os#3397
3573: fix failing RTC initialization for MTS_DRAGONFLY_F411RE ARMmbed/mbed-os#3573
3575: Dev stm factorize gpio ARMmbed/mbed-os#3575
3584: STM32: make PeripheralPins.h a common file ARMmbed/mbed-os#3584
3583: STM32F7 Cube FW new release v1.5.1 ARMmbed/mbed-os#3583
3578: Target system - Inherit names from target parents ARMmbed/mbed-os#3578
3599: K22F: Enable TRNG ARMmbed/mbed-os#3599
3614: STM32: make PortNames.h a common file ARMmbed/mbed-os#3614
3617: EFM32GG: Fix GCC_ARM linker script ARMmbed/mbed-os#3617
3618: STM32: Move types definitions to a common file ARMmbed/mbed-os#3618
3631: F3 CUBE update V1.7.0 ARMmbed/mbed-os#3631
3635: STM32 I2C : Fix bug in i2c_byte_read function ARMmbed/mbed-os#3635
3651: Max32630 - fix LED4 ARMmbed/mbed-os#3651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants