[MAX32630FTHR] Adding new platform #3640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Looks like this test is failing: tests-mbedmicro-rtos-mbed-timer because it expects LED4 to be defined. For LED4, I recommend you define it to any other LED, such as LED_RED. I made this change, re-ran the test and it passes now. Please commit this change and push and it should trigger the CI to run again (or we'll run it again). |
|
Code looks good to me, I got already fix on my local branch (I could not push to their remote branch). I'll create a new PR to fix LED4 define. |
Merged
0xc0170
approved these changes
Jan 27, 2017
aisair
pushed a commit
to aisair/mbed
that referenced
this pull request
Apr 30, 2024
Ports for Upcoming Targets 3571: DISCO_F769NI introduction ARMmbed/mbed-os#3571 3605: Add DELTA_DFCM_NNN50 platform ARMmbed/mbed-os#3605 3640: [MAX32630FTHR] Adding new platform ARMmbed/mbed-os#3640 Fixes and Changes 3397: Add uVisor support for the DISCO_F429ZI ARMmbed/mbed-os#3397 3573: fix failing RTC initialization for MTS_DRAGONFLY_F411RE ARMmbed/mbed-os#3573 3575: Dev stm factorize gpio ARMmbed/mbed-os#3575 3584: STM32: make PeripheralPins.h a common file ARMmbed/mbed-os#3584 3583: STM32F7 Cube FW new release v1.5.1 ARMmbed/mbed-os#3583 3578: Target system - Inherit names from target parents ARMmbed/mbed-os#3578 3599: K22F: Enable TRNG ARMmbed/mbed-os#3599 3614: STM32: make PortNames.h a common file ARMmbed/mbed-os#3614 3617: EFM32GG: Fix GCC_ARM linker script ARMmbed/mbed-os#3617 3618: STM32: Move types definitions to a common file ARMmbed/mbed-os#3618 3631: F3 CUBE update V1.7.0 ARMmbed/mbed-os#3631 3635: STM32 I2C : Fix bug in i2c_byte_read function ARMmbed/mbed-os#3635 3651: Max32630 - fix LED4 ARMmbed/mbed-os#3651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new platform for Maxim MAX32630FTHR
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NONE
Related PRs
List related PRs against other branches:
NONE
Todos
Deploy notes
Notes regarding the deployment of this PR. These should note any
required changes in the build environment, tools, compilers, etc.
Steps to test or reproduce
Outline the steps to test or reproduce the PR here.