STM32F4 cube update from v1.12.0 to v1.16.0

[jeromecoutant]

Description

This is an update of the STM32 F4 STM32 cube (SDK)

Detailed information in targets/TARGET_STM/TARGET_STM32F4/device/Release_Notes_stm32f4xx_hal.html

Status

READY

Tests

The OS2 and OS5 non-regression tests were run successfully in our test bench.

[0xc0170]

/morph test

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 198

Build failed!

[0xc0170]

@jeromecoutant Please look at failures,

06:55:57 [Error] stm32f437xx.h@16815,0:  #18: expected a ")"
06:55:57 [Error] stm32f437xx.h@16815,0:  #77-D: this declaration has no storage class or type specifier
06:55:57 [Error] stm32f437xx.h@16815,0:  #65: expected a ";"

[jeromecoutant]

Please look at failures

done

[0xc0170]

/morph test

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 200

Build failed!

[0xc0170]

the failure above 09:43:42 [DEBUG] Errors: Error: L6218E: Undefined symbol SDIO_DataConfig (referred from cb_mmc.o).

cc @andreaslarssonublox - Can you have a look?

[jeromecoutant]

the failure above 09:43:42 [DEBUG] Errors: Error: L6218E: Undefined symbol SDIO_DataConfig (referred from cb_mmc.o).

Yes, I can't update libublox-odin-w2-driver from my side...

I have a look on the update:
SDIO_DataConfig function is now SDIO_ConfigData .... :-(

[andreaslarssonublox]

Hi, I found two incompatible API changes that affects the ODIN driver:

1. SDIO_DataConfig(SDIO_TypeDef SDIOx, SDIO_DataInitTypeDef SDIO_DataInitStruct) -> HAL_StatusTypeDef SDIO_ConfigData(SDIO_TypeDef SDIOx, SDIO_DataInitTypeDef Data)
   It would be possible to just add another function that defines a deprecated SDIO_DataConfig to stm32f4xx_ll_sdmmc.c/.h

2. SDIO_GetResponse(uint32_t SDIO_RESP) -> SDIO_GetResponse(SDIO_TypeDef *SDIOx, uint32_t Response)
   This is harder since the function has the same name but incompatible parameters changes.

The best thing would be if the driver could be built to work with both old and new but don't know how it can be achieved with the SDIO_GetResponse change.

We plan to do a release of the driver this week. What are the plans for this PR @0xc0170 @jeromecoutant ?

[0xc0170]

Why v1.12.0 to v1.16.0 contains breaking changes? :/
This shall be then targeted for 5.5, and in the meantime to have odin build on top of this one?

@jeromecoutant What do you think?

[bcostm]

Why v1.12.0 to v1.16.0 contains breaking changes?

We (the ST mbed team) are not in charge to develop the HAL driver, it is done by another team. We "just" add it in mbed with less changes as possible. But I agree that such migration issues should not appear. We'll adress this point to the team in charge of the HAL driver to be corrected for the next Cube relase.

This shall be then targeted for 5.5, and in the meantime to have odin build on top of this one?

In fact we need this new HAL version to support the DISCO_F413ZH currently in development/test.
@andreaslarssonublox, if you have already a fix for these 2 functions we can add it into this PR ?

[0xc0170]

We (the ST mbed team) are not in charge to develop the HAL driver, it is done by another team. We "just" add it in mbed with less changes as possible. But I agree that such migration issues should not appear. We'll adress this point to the team in charge of the HAL driver to be corrected for the next Cube relase.

Thanks, that will be good ! This should be 2.0.0 :-)

In fact we need this new HAL version to support the DISCO_F413ZH currently in development/test.
@andreaslarssonublox, if you have already a fix for these 2 functions we can add it into this PR ?

If there is a new API and its just a rename, can we do it backward compatible (add the previous one that calls a new one) ? @bcostm would that work? Or any other proposals?

[jeromecoutant]

Morph test has to be started again after #4338 merge
Thx

[0xc0170]

/morph test

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 274

Example Build failed!

[studavekar]

The fix #4353 is merged in master

/morph test

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 283

All builds and test passed!