-
Notifications
You must be signed in to change notification settings - Fork 3k
Add static to NRF5 SDK11 macro definition #4353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
@adbridge You will want to re-create the Release with this patch included to pass nightlys |
@theotherjimmy It was unnoticed by the CI job running BLE because IAR are deactivated atm for PRs due to an internal issue. Apologies for the inconvenient time, fortunately the CI issue will be resolve soon and IAR support will be covered in PR builds, not just nightly builds. |
@nvlsianpu |
The IAR version should also have the static storage class specifier. This will be fixed in upcoming versions of the nRF5 SDKs. |
As Frank respond: looks fine for use. |
This is blocking CI
Description
After ARMmbed/mbed-os-example-ble#80 was merged, the Austin Example build CI correctly started failing for NRF51_DK and NRF52_DK with IAR with a mulitple symbol definition:
This PR adds static to the NRF_SECTION_VARS_ADD macro for IAR because it's present on the other 2 compilers.
Status
READY
Todos
Steps to test or reproduce
Try building the BLE_EddystoneService with the latest mbed-os master.