Skip to content

Revert partially "Remove Cortex A support from CMSIS/RTOS" #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2017
Merged

Revert partially "Remove Cortex A support from CMSIS/RTOS" #4334

merged 1 commit into from
May 22, 2017

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented May 17, 2017

This reverts commit 5f29445 - but only partially.

cmain.S for IAR is still required to keep mbed SDK boot process as it was. This
startup file for IAR is active for non-rtos projects.

Fixes #4330

Thanks to @YarivCol for reporting this. Tested locally with blinky mbed OS and mbed-dev gpio example (K64F board) - thus should be compatible with all new changes (new mbed boot that is coming to mbed OS).

@0xc0170
Revert partially "Remove Cortex A support from CMSIS/RTOS"
e0dded3 
This reverts commit 5f29445 - but only partially.

cmain.S for IAR is still required to keep mbed SDK boot process as it was. This
startup file for IAR is active for non-rtos projects.

Fixes ARMmbed#4330
@0xc0170 0xc0170 requested review from bulislaw and c1728p9 May 17, 2017 13:17
@bulislaw
Copy link
Member

I'm assuming this file fills the space in mbed_sdk_boot.c:

#elif defined (__ICCARM__)

// empty for now

#endif

Can we change the comment to say that's done int the cmsis/TOOLCHAIN_IAR/cmain.S file and also document addition of the external file to cmsis in ARMmbed/mbed-os-5-docs#160

@0xc0170
Copy link
Contributor Author

0xc0170 commented May 17, 2017

Both done (new commits on both PR)

@0xc0170
Copy link
Contributor Author

0xc0170 commented May 17, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 249

Test failed!

@0xc0170
Copy link
Contributor Author

0xc0170 commented May 18, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 255

Test failed!

@0xc0170
Copy link
Contributor Author

0xc0170 commented May 18, 2017

@bridadan @studavekar K22F is down (see the latest morph result)

@0xc0170 0xc0170 mentioned this pull request May 19, 2017
Merged
@0xc0170
Copy link
Contributor Author

0xc0170 commented May 19, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 275

Example Build failed!

@studavekar
Copy link
Contributor

The fix #4353 is merged in master

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 285

All builds and test passed!

@bulislaw
Copy link
Member

Great!

@0xc0170 0xc0170 merged commit a567afd into ARMmbed:master May 22, 2017
@0xc0170 0xc0170 deleted the fix_issue4330 branch May 26, 2017 10:36
@jeromecoutant
Copy link
Collaborator

Hi
I still can see an issue with IAR...

Test MBED_A21 (https://github.com/ARMmbed/mbed-os/blob/master/features/unsupported/tests/mbed/call_before_main/main.cpp)
is FAIL only for IAR for all the targets I checked.

I have opened #4602

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@YarivCol YarivCol YarivCol approved these changes

@c1728p9 c1728p9 Awaiting requested review from c1728p9

Assignees
No one assigned
Labels
release-version: 5.4.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@0xc0170 @bulislaw @mbed-bot @studavekar @jeromecoutant @YarivCol @sg- @adbridge