Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RTX error handlers into RTX handler file #4817

Merged
merged 1 commit into from
Aug 14, 2017
Merged

Move RTX error handlers into RTX handler file #4817

merged 1 commit into from
Aug 14, 2017
+70 −69

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Jul 26, 2017

Move the RTX error handlers out of mbed_retarget.cpp and into the dedicated RTX handler file.

@c1728p9 c1728p9 requested a review from bulislaw July 26, 2017 15:32
@c1728p9
Copy link
Contributor Author

c1728p9 commented Jul 26, 2017

/morph test

bulislaw
bulislaw reviewed Jul 26, 2017
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could try printing some names, especially that we name all the object created by the system.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Jul 26, 2017

This patch is just a refactor which moves them to a different location. Enhancing the information printed can be done in a separate PR.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Jul 26, 2017

retest uvisor

bulislaw
bulislaw approved these changes Jul 26, 2017
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, lgtm

@bulislaw
Copy link
Member

Just to grumble a bit more ;) Not saying it has to be part of this PR. The MBED_TRAP_ERRORS_ENABLED could be connected to debug build profile or documented somewhere. The only thing i found is https://developer.mbed.org/blog/entry/mbed-OS-Planned-API-and-Toolchain-Change/

@theotherjimmy
Copy link
Contributor

@bulislaw Move that to an issue. We should have those "grumbles" documented somewhere other than a PR that seems to be setup for quick merging.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Jul 26, 2017

Actually, MBED_TRAP_ERRORS_ENABLED is enabled in the debug profile

@bulislaw
Copy link
Member

Ah indeed! The default github search didn't show me the .json file.

@theotherjimmy
Copy link
Contributor

Failure looks related.

Compile [ 79.1%]: mbed_rtx_handlers.c
[Error] mbed_rtx_handlers.c@120,19: 'osRtxErrorSemaphoreCountLimit' undeclared (first use in this function)

@c1728p9
Move RTX error handlers into RTX handler file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
46f6f52 
Move the RTX error handlers out of mbed_retarget.cpp and into an the
dedicated RTX handler file.
@c1728p9 c1728p9 force-pushed the move_rtx_handlers branch from c4f01c9 to 46f6f52 Compare July 27, 2017 15:09
@c1728p9
Copy link
Contributor Author

c1728p9 commented Jul 27, 2017

/morph test

@theotherjimmy
Copy link
Contributor

@studavekar Another non-reporter.

@studavekar
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 917

Example Prep failed!

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 4, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Aug 4, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 939

Example Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 7, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Aug 7, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 953

Build failed!

@theotherjimmy
Copy link
Contributor

/morph test

@studavekar
Copy link
Contributor

Have updated the status to success

Results : http://mbed-ci-master-2.austin.arm.com:8081/job/pr_pipeline/992/

@theotherjimmy theotherjimmy merged commit 99a8467 into ARMmbed:master Aug 14, 2017
exmachina-auto-deployer pushed a commit to exmachina-dev/mbed-os that referenced this pull request Sep 13, 2017
@WillyKaze
Merge tag 'mbed-os-5.5.6' of github.com:ARMmbed/mbed-os into 5.5.6
1fc92cd 
mbed OS 5.5.6 release

We are pleased to announce the [mbed OS 5.5.6
release](https://github.com/ARMmbed/mbed-os/releases/tag/mbed-os-5.5.6)
is now available.

This release includes ...

Known Issues

The following list of known issues apply to this release:

Contents

Ports for Upcoming Targets

[4608](ARMmbed#4608)
Support Nuvoton's new target NUMAKER_PFM_M487

[4840](ARMmbed#4840)
Add Support for TOSHIBA TMPM066 board

Fixes and Changes

[4801](ARMmbed#4801)
STM32 CAN: Fix issue with speed function calculation

[4808](ARMmbed#4808)
Make HAL & US tickers idle safe

[4812](ARMmbed#4812)
Use DSPI SDK driver API's in SPI HAL driver

[4832](ARMmbed#4832)
NUC472/M453: Fix several startup and hal bugs

[4842](ARMmbed#4842)
Add call to DAC_Enable as this is no longer done as part

[4849](ARMmbed#4849)
Allow using of malloc() for reserving the Nanostack's heap.

[4850](ARMmbed#4850)
Add list of defines to vscode exporter

[4863](ARMmbed#4863)
Optimize memory usage of wifi scan for REALTEK_RTW8195AM

[4869](ARMmbed#4869)
HAL LPCs SPI: Fix mask bits for SPI clock rate

[4873](ARMmbed#4873)
Fix Cortex-A cache file

[4878](ARMmbed#4878)
STM32 : Separate internal ADC channels with new pinmap

[4392](ARMmbed#4392)
Enhance memap, and configure depth level

[4895](ARMmbed#4895)
Turn on doxygen for DEVICE_* features

[4817](ARMmbed#4817)
Move RTX error handlers into RTX handler file

[4902](ARMmbed#4902)
Using CMSIS/RTX Exclusive access macro

[4923](ARMmbed#4923)
fix export static_files to zip

[4844](ARMmbed#4844)
bd: Add ProfilingBlockDevice for measuring higher-level applications

[4896](ARMmbed#4896)
target BLUEPILL_F103C8 compile fix

[4921](ARMmbed#4921)
Update gcc-arm-embedded PPA in Travis

[4926](ARMmbed#4926)
STM32L053x8: Refactor NUCLEO_L053R8 and DISCO_L053C8 targets

[4831](ARMmbed#4831)
Remove excessive use of printf/scanf in mbed_fdopen/_open

[4922](ARMmbed#4922)
bug fix: xdot clock config

[4935](ARMmbed#4935)
STM32: fix F410RB vectors size

[4940](ARMmbed#4940)
Update mbed-coap to version 4.0.9

[4941](ARMmbed#4941)
Update of MemoryPool.h header file.

You can fetch this release from the [mbed-os
GitHub](https://github.com/ARMmbed/mbed-os) repository,
using the tag "mbed-os-5.5.6".

Please feel free to ask any questions or provide feedback on this
release [on the forum](https://forums.mbed.com/),
or to contact us at [support@mbed.org](mailto:support@mbed.org).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw

@0xc0170 0xc0170

Assignees
No one assigned
Labels
release-version: 5.5.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@c1728p9 @bulislaw @theotherjimmy @studavekar @mbed-bot @0xc0170