NUC472/M453: Fix several startup and hal bugs #4832

ccli8 · 2017-07-31T08:52:22Z

Description

This PR includes enhancements and bugfixes for NUMAKER_PFM_NUC472 and NUMAKER_PFM_M453 targets.

Fix region end address error with IAR toolchain.
Fix RTC time doesn't continue across reset cycle.
Conform to mbed TLS H/W acceleration support (NUC472).
Move target configuration from mbed_lib.json to targets.json.
Fix SPI mode error.
Other code and comment refinement.

theotherjimmy · 2017-07-31T14:40:31Z

@ccli8 Thanks for the PR. We use the PR titles in release notes, which are formatted with markdown. The [ and ] characters are markdown syntax for a link, which I don't thin is your intent. Could you replace them with a :? Further, we prefer that the release notes use the imparative mood. Could you change the title to match that? I think something like NUC472/M453: Fix several startup and hal bugs would meet these requirements, and better describe the contents of the PR.

theotherjimmy · 2017-07-31T14:57:56Z

@ccli8 The travis CI error is related to #4839 and should be resolved if you rebase.

…future protected register access

1. With mbed OS 5, mbed_sdk_init() is ensured to call before C++ global object constructor. 2. Refine startup file with GCC_ARM toolchain related to this modification.

No real LED4. Just for passing ATS.

….json

ccli8 · 2017-08-01T09:37:20Z

@theotherjimmy I've changed the PR title and rebase. Please check it.

0xc0170 · 2017-08-01T14:16:42Z

It would be easier to send this as separate patches. Helps to review/integrate.

These commits are nice series of logical patches 👍

0xc0170 · 2017-08-09T08:14:50Z

Conform to mbed TLS H/W acceleration support (NUC472).

@RonEld @yanesca @andresag01 Please review

0xc0170

LGTM, just that small one that does not affect functionality.

0xc0170 · 2017-08-09T08:13:05Z

targets/TARGET_NUVOTON/TARGET_M451/rtc_api.c

+    }
+
+    // NOTE: Check RTC Init Active flag to support crossing reset cycle.
+    return  !! (RTC->INIT & RTC_INIT_ACTIVE_Msk);


this double !! is not necessary here?

@0xc0170 The double !! converts non-0 value to 1. In mbed-os/hal/rtc_api.h:

/** Get the RTC enable status * * @retval 0 disabled * @retval 1 enabled */ int rtc_isenabled(void);

theotherjimmy · 2017-08-10T14:30:23Z

/morph test

mbed-bot · 2017-08-11T00:01:20Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 996

Build failed!

studavekar · 2017-08-11T03:39:27Z

/morph test

mbed-bot · 2017-08-11T05:54:34Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1010

Build Prep failed!

studavekar · 2017-08-11T14:35:30Z

/morph test

mbed-bot · 2017-08-11T14:37:48Z

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1018

Build Prep failed!

studavekar · 2017-08-11T20:49:12Z

/morph test

mbed-bot · 2017-08-12T02:38:02Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1022

All builds and test passed!

0xc0170 · 2017-08-14T05:49:10Z

Conform to mbed TLS H/W acceleration support (NUC472).
@RonEld @yanesca @andresag01 Please review

Any review?

RonEld

I added one small comment, of unneeded definitions in mbedtls_device.h

RonEld · 2017-08-16T10:51:14Z

...ures/mbedtls/targets/TARGET_NUVOTON/TARGET_NUC472/TARGET_NUMAKER_PFM_NUC472/mbedtls_device.h

+#define MBEDTLS_SHA256_ALT
+
+#define MBEDTLS_AES_ALT
+#define MBEDTLS_AES_SETKEY_ENC_ALT


if MBEDTLS_AES_ALT is defined, no need to define other Alternative configuration for AES, as MBEDTLS_AES_ALT defines alternative implementation for the whole module

@RonEld I fixed it. Please check another PR 63e4fb8.

mbed OS 5.5.6 release We are pleased to announce the [mbed OS 5.5.6 release](https://github.com/ARMmbed/mbed-os/releases/tag/mbed-os-5.5.6) is now available. This release includes ... Known Issues The following list of known issues apply to this release: Contents Ports for Upcoming Targets [4608](ARMmbed#4608) Support Nuvoton's new target NUMAKER_PFM_M487 [4840](ARMmbed#4840) Add Support for TOSHIBA TMPM066 board Fixes and Changes [4801](ARMmbed#4801) STM32 CAN: Fix issue with speed function calculation [4808](ARMmbed#4808) Make HAL & US tickers idle safe [4812](ARMmbed#4812) Use DSPI SDK driver API's in SPI HAL driver [4832](ARMmbed#4832) NUC472/M453: Fix several startup and hal bugs [4842](ARMmbed#4842) Add call to DAC_Enable as this is no longer done as part [4849](ARMmbed#4849) Allow using of malloc() for reserving the Nanostack's heap. [4850](ARMmbed#4850) Add list of defines to vscode exporter [4863](ARMmbed#4863) Optimize memory usage of wifi scan for REALTEK_RTW8195AM [4869](ARMmbed#4869) HAL LPCs SPI: Fix mask bits for SPI clock rate [4873](ARMmbed#4873) Fix Cortex-A cache file [4878](ARMmbed#4878) STM32 : Separate internal ADC channels with new pinmap [4392](ARMmbed#4392) Enhance memap, and configure depth level [4895](ARMmbed#4895) Turn on doxygen for DEVICE_* features [4817](ARMmbed#4817) Move RTX error handlers into RTX handler file [4902](ARMmbed#4902) Using CMSIS/RTX Exclusive access macro [4923](ARMmbed#4923) fix export static_files to zip [4844](ARMmbed#4844) bd: Add ProfilingBlockDevice for measuring higher-level applications [4896](ARMmbed#4896) target BLUEPILL_F103C8 compile fix [4921](ARMmbed#4921) Update gcc-arm-embedded PPA in Travis [4926](ARMmbed#4926) STM32L053x8: Refactor NUCLEO_L053R8 and DISCO_L053C8 targets [4831](ARMmbed#4831) Remove excessive use of printf/scanf in mbed_fdopen/_open [4922](ARMmbed#4922) bug fix: xdot clock config [4935](ARMmbed#4935) STM32: fix F410RB vectors size [4940](ARMmbed#4940) Update mbed-coap to version 4.0.9 [4941](ARMmbed#4941) Update of MemoryPool.h header file. You can fetch this release from the [mbed-os GitHub](https://github.com/ARMmbed/mbed-os) repository, using the tag "mbed-os-5.5.6". Please feel free to ask any questions or provide feedback on this release [on the forum](https://forums.mbed.com/), or to contact us at [support@mbed.org](mailto:support@mbed.org).

theotherjimmy added the needs: work label Jul 31, 2017

ccli8 and others added 12 commits August 1, 2017 14:39

[NUC472/M453] Fix region end address error with IAR toolchain

c4df35d

[NUC472/M453] Fix RTC time doesn't continue across reset cycle

2844be6

[NUC472/M453] Move SystemInit() to register unlock range for perhaps …

8067f9a

…future protected register access

[NUC472] Conform to mbed TLS H/W acceleration support

46cb684

[NUC472/M453] Add comment in gpio_irq_init()

ea7a0fd

[NUC472/M453] Fix lp_ticker typo

6c9fda4

[NUC472/M453] Remove mbed_sdk_init_forced()

ea1de8c

1. With mbed OS 5, mbed_sdk_init() is ensured to call before C++ global object constructor. 2. Refine startup file with GCC_ARM toolchain related to this modification.

[NUC472/M453] Set LED4 to LED1

5e335de

No real LED4. Just for passing ATS.

[NUC472/M453] Add sanity check for serial format

c7fcd07

[NUC472/M453] Add comment for Receive Time-out IF in SPI HAL

8092c36

[NUC472/M453] Move target configuration from mbed_lib.json to targets…

d885de6

….json

[NUC472] Sync SPI mode with NUC472 BSP V3.02.001

6b8724b

ccli8 changed the title ~~[NUC472/M453] Some enhancements and bugfixes~~ NUC472/M453: Fix several startup and hal bugs Aug 1, 2017

ccli8 force-pushed the nuvoton branch from 99d1b94 to 6b8724b Compare August 1, 2017 09:28

theotherjimmy added needs: review and removed needs: work labels Aug 7, 2017

0xc0170 approved these changes Aug 9, 2017

View reviewed changes

0xc0170 approved these changes Aug 10, 2017

View reviewed changes

theotherjimmy added needs: CI and removed needs: review labels Aug 10, 2017

theotherjimmy added ready for merge and removed needs: CI labels Aug 14, 2017

theotherjimmy merged commit 0f0a461 into ARMmbed:master Aug 14, 2017

theotherjimmy added release-version: 5.5.6 and removed ready for merge labels Aug 14, 2017

RonEld reviewed Aug 16, 2017

View reviewed changes

ccli8 mentioned this pull request Aug 17, 2017

NUC472/M487: Refine code with mbed TLS crypto alternatives #4925

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NUC472/M453: Fix several startup and hal bugs #4832

NUC472/M453: Fix several startup and hal bugs #4832

ccli8 commented Jul 31, 2017

theotherjimmy commented Jul 31, 2017

theotherjimmy commented Jul 31, 2017

ccli8 commented Aug 1, 2017

0xc0170 commented Aug 1, 2017

0xc0170 commented Aug 9, 2017

0xc0170 left a comment

0xc0170 Aug 9, 2017

ccli8 Aug 9, 2017

theotherjimmy commented Aug 10, 2017

mbed-bot commented Aug 11, 2017 •

edited

Loading

studavekar commented Aug 11, 2017

mbed-bot commented Aug 11, 2017

studavekar commented Aug 11, 2017

mbed-bot commented Aug 11, 2017

studavekar commented Aug 11, 2017

mbed-bot commented Aug 12, 2017

0xc0170 commented Aug 14, 2017

RonEld left a comment

RonEld Aug 16, 2017

ccli8 Aug 17, 2017

NUC472/M453: Fix several startup and hal bugs #4832

NUC472/M453: Fix several startup and hal bugs #4832

Conversation

ccli8 commented Jul 31, 2017

Description

theotherjimmy commented Jul 31, 2017

theotherjimmy commented Jul 31, 2017

ccli8 commented Aug 1, 2017

0xc0170 commented Aug 1, 2017

0xc0170 commented Aug 9, 2017

0xc0170 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theotherjimmy commented Aug 10, 2017

mbed-bot commented Aug 11, 2017 • edited Loading

Output

studavekar commented Aug 11, 2017

mbed-bot commented Aug 11, 2017

Output

studavekar commented Aug 11, 2017

mbed-bot commented Aug 11, 2017

Output

studavekar commented Aug 11, 2017

mbed-bot commented Aug 12, 2017

Output

0xc0170 commented Aug 14, 2017

RonEld left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbed-bot commented Aug 11, 2017 •

edited

Loading